56 add strata to desk review spreadsheets #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
dfsnow
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@Damonamajor Per my note on this in-person, you'll also need to modify the template file (misc/desk_review_template.xlsx) and the lines below this to insert the new columns into the Excel workbook.
* Add gaa to eval run_id variable * Hide source code for conditionally included Quarto chunks * Fix code echoed in Quarto doc * Revert default run_id
* Fix missing geography_id for triads * Remove geography_id in mutate()
* Add test * Update reports/performance/_outliers.qmd Co-authored-by: Dan Snow <[email protected]> * lintr --------- Co-authored-by: Dan Snow <[email protected]>
* Replace arrows with equal signs * Revert unload change
* Update params to match residential model * Hide echoed code in model reports * Plot variance wrt time * Update training data * Remove multi-card filter * Update DVC lockfile
Merge branch '2025-assessment-year' of github.com:ccao-data/model-condo-avm into 56-add-strata-to-desk-review-spreadsheets # Conflicts: # renv.lock # reports/_setup.R # reports/performance/_model.qmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #56 which is the result of creating a flag for imputed strata values and recoding values through this #55.