Ensure reporting.vw_pin_most_recent_sale rowcount is correct before ias rollover
#698
Conversation
| AND deactivat IS NULL | ||
| -- noqa: disable=RF02 |
There was a problem hiding this comment.
There may be a bug in RF02 in our version of SQLFluff, since this block doesn't seem to me to represent an unqualified reference. It doesn't raise an error, but the warning is annoying, so I ignore it just for this block.
| # Rowcount will typically exceed iasworld.pardat due to sales with | ||
| # PINs that are not in pardat, but at a minimum we want one row | ||
| # for each PIN that we know about in pardat |
There was a problem hiding this comment.
We could make this even more accurate by joining to pardat by PIN, but that would make the test more complicated and I think the simple rowcount is good enough to catch cases like the one that inspired this PR.
There was a problem hiding this comment.
Thanks for fixing this @jeancochrane. I should check our other views from any use of CURRENT_DATE that might lead to similar issues.
I took a quick look, and everything else that uses |
jeancochrane
deleted the
jeancochrane/account-for-ias-rollover-in-most-recent-sale-view
branch
The
reporting.vw_pin_most_recent_saleview currently has the wrong number of rows since its query filtersiasworld.pardatbyYEAR(CURRENT_DATE), but we don't have 2025 data in iasWorld as the rollover hasn't happened yet. We got notified of this bug by our weekly tests, which failed this morning.This PR updates
reporting.vw_pin_most_recent_saleso that it filters pardat for the most recent available year in that table. It also simplifies the rowcount tests for the model to be more accurate and easier to debug.