[1/3] Migrate Will's town close QC reports to dbt models

.flake8

@@ -0,0 +1,6 @@
+[flake8]
+ignore=
+    # Whitespace before ':', incompatible with black
+    E203,
+    # Line break before binary operator, incompatible with black
+    W503

dbt/models/qc/docs.md

@@ -104,11 +104,41 @@ investigated.
 
 {% enddocs %}
 
-# vw_report_neg_asmt_value
+# vw_sale_mydec_null_values
+
+{% docs view_vw_sale_mydec_null_values %}
+Test that deed, buyer, seller, address and price `sale.mydec` columns are not
+null.
+
+{% enddocs %}
+
+# vw_iasworld_asmt_all_joined_to_legdat
+
+{% docs view_vw_iasworld_asmt_all_joined_to_legdat %}
+View that joins `iasworld.asmt_all` to `iasworld.legdat` to augment `asmt_all`
+with parcel legal descriptions and addresses.
+
+Both views are already filtered for current active records.
+{% enddocs %}
+
+# vw_iasworld_asmt_all_with_prior_year_values
 
-{% docs view_vw_report_neg_asmt_value %}
+{% docs view_vw_iasworld_asmt_all_with_prior_year_values %}
+View that joins `iasworld.asmt_all` to its prior year values for comparison.
+Also pulls parcel data from `LEGDAT`, `PARDAT`, `OWNDAT`, and `APRVAL`
+for context.
+
+This view is used as the basis for a number of town close QC reports.
+{% enddocs %}
+
+# vw_report_town_close_neg_asmt_value
+
+{% docs view_vw_report_town_close_neg_asmt_value %}
 Check for `ASMT.val*` columns that are negative.
 
+This view is exported as part of the QC report to check values prior to town
+closings.
+
 Pulled from the following Inquire queries:
 
 - `FP Checklist - Negative ASMT Values` (#1569) - Will C.
@@ -117,19 +147,88 @@ In contrast to `qc.vw_neg_asmt_value`, this view directly performs filtering
 for negative values.
 {% enddocs %}
 
-# vw_sale_mydec_null_values
+# vw_report_town_close_0_land_value
 
-{% docs view_vw_sale_mydec_null_values %}
-Test that deed, buyer, seller, address and price `sale.mydec` columns are not
-null.
+{% docs view_vw_report_town_close_0_land_value %}
+Check for parcels that have 0 land value in the `ASMT` table.
 
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - Non-EX, RR parcels with 0 land value` (#1578) - Will C.
 {% enddocs %}
 
-# vw_iasworld_asmt_all_joined_to_legdat
+# vw_report_town_close_0_value
 
-{% docs view_vw_iasworld_asmt_all_joined_to_legdat %}
-View that joins `iasworld.asmt_all` to `iasworld.legdat` to augment `asmt_all`
-with parcel legal descriptions and addresses.
+{% docs view_vw_report_town_close_0_value %}
+Check for parcels that have 0 total value in the `ASMT` table.
 
-Both views are already filtered for current active records.
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - Non-EX, RR parcels with 0 value` (#1570) - Will C.
+{% enddocs %}
+
+# vw_report_town_close_vacant_class_with_bldg_value
+
+{% docs view_vw_report_town_close_vacant_class_with_bldg_value %}
+Check for parcels that have a vacant class in the `PARDAT` table, but a
+building value in the `ASMT` table.
+
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - Vacant Class, bldg value` (#1577) - Will C.
+{% enddocs %}
+
+# vw_report_town_close_improved_class_without_bldg_value
+
+{% docs view_vw_report_town_close_improved_class_without_bldg_value %}
+Check for parcels that have a non-vacant class in the `PARDAT` table, but no
+building value in the `ASMT` table.
+
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - Improved Class, no bldg value` (#1047) - Will C.
+{% enddocs %}
+
+# vw_report_town_close_class_does_not_equal_luc
+
+{% docs view_vw_report_town_close_class_does_not_equal_luc %}
+Check for parcels where the class does not match the land use code in
+the `PARDAT` table.
+
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - Class does not equal LUC` (#2046) - Will C.
+{% enddocs %}
+
+# vw_report_town_close_500k_increase_1m_decrease
+
+{% docs view_vw_report_town_close_500k_increase_1m_decrease %}
+Check for rows in the  `ASMT` table where the total market value has increased
+by more than $500k or decreased by more than $1m in the past year.
+
+This view is exported as part of the QC report to check values prior to town
+closings.
+
+Pulled from the following Inquire queries:
+
+- `FP Checklist - 500k increase, 1m decrease` (#1673) - Will C.
+- `FP Checklist - Card Code Info` (#2160) - Will C.
+{% enddocs %}
+
+- `FP Checklist - Prior Yr Card Code 5s OBY` (#1585) - Will C.
 {% enddocs %}

dbt/models/qc/qc.vw_change_in_ahsap_values.sql

@@ -22,6 +22,3 @@ WHERE ahsap.ahsap
         OR hist.certified_tot > hist.mailed_tot * 1.2
         OR hist.board_tot > hist.certified_tot * 1.2
     )
-    AND CAST(
-        hist.year AS INT
-    ) BETWEEN {{ var('test_qc_year_start') }} AND {{ var('test_qc_year_end') }}

dbt/models/qc/qc.vw_iasworld_asmt_all_with_prior_year_values.sql

@@ -0,0 +1,52 @@
+SELECT
+    legdat.parid,
+    asmt.taxyr,
+    legdat.user1 AS township_code,
+    pardat.nbhd,
+    pardat.class,
+    pardat.luc,
+    owndat.own1,
+    aprval.reascd,
+    aprval.who,
+    asmt_prev.valapr1 AS valapr1_prev,
+    asmt_prev.valapr2 AS valapr2_prev,
+    asmt_prev.valapr3 AS valapr3_prev,
+    asmt_prev.valasm1 AS valasm1_prev,
+    asmt_prev.valasm2 AS valasm2_prev,
+    asmt_prev.valasm3 AS valasm3_prev,
+    asmt.valapr1,
+    asmt.valapr2,
+    asmt.valapr3,
+    asmt.valasm1,
+    asmt.valasm2,
+    asmt.valasm3
+FROM {{ source('iasworld', 'asmt_all') }} AS asmt
+LEFT JOIN {{ source('iasworld', 'asmt_all') }} AS asmt_prev
+    ON asmt.parid = asmt_prev.parid
+    AND CAST(asmt.taxyr AS INT) = CAST(asmt_prev.taxyr AS INT) + 1
+    AND asmt_prev.cur = 'Y'
+    AND asmt_prev.deactivat IS NULL
+    AND asmt_prev.valclass IS NULL
+LEFT JOIN {{ source('iasworld', 'legdat') }} AS legdat
+    ON asmt.taxyr = legdat.taxyr
+    AND asmt.parid = legdat.parid
+    AND legdat.cur = 'Y'
+    AND legdat.deactivat IS NULL
+LEFT JOIN {{ source('iasworld', 'pardat') }} AS pardat
+    ON asmt.taxyr = pardat.taxyr
+    AND asmt.parid = pardat.parid
+    AND pardat.cur = 'Y'
+    AND pardat.deactivat IS NULL
+LEFT JOIN {{ source('iasworld', 'owndat') }} AS owndat
+    ON asmt.taxyr = owndat.taxyr
+    AND asmt.parid = owndat.parid
+    AND owndat.cur = 'Y'
+    AND owndat.deactivat IS NULL
+LEFT JOIN {{ source('iasworld', 'aprval') }} AS aprval
+    ON asmt.taxyr = aprval.taxyr
+    AND asmt.parid = aprval.parid
+    AND aprval.cur = 'Y'
+    AND aprval.deactivat IS NULL
+WHERE asmt.cur = 'Y'
+    AND asmt.deactivat IS NULL
+    AND asmt.valclass IS NULL

dbt/models/qc/qc.vw_report_town_close_0_land_value.sql

@@ -0,0 +1,28 @@
+SELECT
+    parid,
+    taxyr,
+    township_code,
+    class,
+    own1,
+    reascd,
+    who,
+    valapr1_prev,
+    valapr2_prev,
+    valapr3_prev,
+    valasm1_prev,
+    valasm2_prev,
+    valasm3_prev,
+    valapr1,
+    valapr2,
+    valapr3,
+    valasm1,
+    valasm2,
+    valasm3
+FROM {{ ref('qc.vw_iasworld_asmt_all_with_prior_year_values') }}
+WHERE valasm1 = 0
+    AND class NOT IN ('EX', 'RR')
+    -- Filter out leasehold parcels. We are not yet sure if there is a
+    -- definitive field for marking leasehold parcels, but in the meantime
+    -- the reports have historically followed the heuristic of filtering out
+    -- parcel IDs where the 11th digit is an 8
+    AND SUBSTR(parid, 11, 1) != '8'

dbt/models/qc/qc.vw_report_town_close_0_value.sql

@@ -0,0 +1,23 @@
+SELECT
+    parid,
+    taxyr,
+    township_code,
+    class,
+    own1,
+    reascd,
+    who,
+    valapr1_prev,
+    valapr2_prev,
+    valapr3_prev,
+    valasm1_prev,
+    valasm2_prev,
+    valasm3_prev,
+    valapr1,
+    valapr2,
+    valapr3,
+    valasm1,
+    valasm2,
+    valasm3
+FROM {{ ref('qc.vw_iasworld_asmt_all_with_prior_year_values') }}
+WHERE valasm3 = 0
+    AND class NOT IN ('EX', 'RR')

dbt/models/qc/qc.vw_report_town_close_500k_increase_1m_decrease.sql

@@ -0,0 +1,92 @@
+WITH card_code_info AS (
+    SELECT
+        pardat.parid,
+        pardat.taxyr,
+        CASE
+            WHEN
+                CONTAINS(
+                    ARRAY_AGG(SUBSTRING(COALESCE(dweldat.mktrsn, ''), 1, 1)),
+                    '5'
+                )
+                THEN 'Y'
+            ELSE ''
+        END AS dweldat_code_5,
+        CASE
+            WHEN
+                CONTAINS(
+                    ARRAY_AGG(SUBSTRING(COALESCE(comdat.chgrsn, ''), 1, 1)), '5'
+                )
+                THEN 'Y'
+            ELSE ''
+        END AS comdat_code_5,
+        CASE
+            WHEN
+                CONTAINS(
+                    ARRAY_AGG(SUBSTRING(COALESCE(oby.chgrsn, ''), 1, 1)), '5'
+                )
+                THEN 'Y'
+            ELSE ''
+        END AS oby_code_5
+    FROM {{ source('iasworld', 'pardat') }} AS pardat
+    LEFT JOIN {{ source('iasworld', 'dweldat') }} AS dweldat
+        ON pardat.parid = dweldat.parid
+        AND pardat.taxyr = dweldat.taxyr
+        AND dweldat.cur = 'Y'
+        AND dweldat.deactivat IS NULL
+    LEFT JOIN {{ source('iasworld', 'comdat') }} AS comdat
+        ON pardat.parid = comdat.parid
+        AND pardat.taxyr = comdat.taxyr
+        AND comdat.cur = 'Y'
+        AND comdat.deactivat IS NULL
+    LEFT JOIN {{ source('iasworld', 'oby') }} AS oby
+        ON pardat.parid = oby.parid
+        AND pardat.taxyr = oby.taxyr
+        AND oby.cur = 'Y'
+        AND oby.deactivat IS NULL
+    WHERE pardat.cur = 'Y'
+        AND pardat.deactivat IS NULL
+    GROUP BY pardat.parid, pardat.taxyr
+)
+
+SELECT
+    asmt.parid,
+    asmt.taxyr,
+    asmt.township_code,
+    asmt.class,
+    asmt.reascd,
+    asmt.valapr1_prev,
+    asmt.valapr2_prev,
+    asmt.valapr3_prev,
+    asmt.valapr1,
+    asmt.valapr2,
+    asmt.valapr3,
+    asmt.valapr3 - asmt.valapr3_prev AS difference,
+    CASE
+        WHEN asmt.valapr3_prev != 0
+            THEN CONCAT(
+                CAST(
+                    ROUND(
+                        (
+                            (asmt.valapr3 - asmt.valapr3_prev)
+                            / CAST(asmt.valapr3_prev AS DOUBLE)
+                        )
+                        * 100,
+                        2
+                    ) AS VARCHAR
+                ),
+                '%'
+            )
+    END AS percent_change,
+    code.dweldat_code_5,
+    code.comdat_code_5,
+    code.oby_code_5
+FROM {{ ref('qc.vw_iasworld_asmt_all_with_prior_year_values') }} AS asmt
+LEFT JOIN card_code_info AS code
+    ON asmt.parid = code.parid
+    -- Join to prior year card code info, since we want to know the code value
+    -- last year
+    AND CAST(CAST(asmt.taxyr AS INT) - 1 AS VARCHAR) = code.taxyr
+WHERE (
+    asmt.valapr3 - asmt.valapr3_prev >= 500000
+    OR asmt.valapr3 - asmt.valapr3_prev <= -1000000
+)

dbt/models/qc/qc.vw_report_town_close_class_does_not_equal_luc.sql

@@ -0,0 +1,23 @@
+SELECT
+    parid,
+    taxyr,
+    township_code,
+    class,
+    luc,
+    own1,
+    reascd,
+    who,
+    valapr1_prev,
+    valapr2_prev,
+    valapr3_prev,
+    valasm1_prev,
+    valasm2_prev,
+    valasm3_prev,
+    valapr1,
+    valapr2,
+    valapr3,
+    valasm1,
+    valasm2,
+    valasm3
+FROM {{ ref('qc.vw_iasworld_asmt_all_with_prior_year_values') }}
+WHERE class != luc