Added notify function to pocket api

[IvoLeal72]

pocket.notify() makes the led blink green and then return to previous color, and beeps 3 times, only to the player that is holding it and broadcast if no player is holding it

Possible solution for #1148

[Wojbie]

I do believe that pockets not in player inventory are supposed to shut down, is no-player logic supposed to be some kind of future proofing?

[IvoLeal72]

I forgot about that haha. That is completely true, it's fun to make it notify and throw it, but kinda useless yeah, I can remove it

[zyxkad]

Instead of block the thread, can you use timer/ticker?

[zyxkad]

Or just do this at client side

[IvoLeal72]

Hello, I know the PR is closed, but I'm curious on how to do this, can you give me some help, or forward me to some documentation/tutorial? I'm completely new to minecraft modding, though I have some years of experience with java

[zyxkad]

Basiclly what I mean is async programming. You should register a listener when tick executes, and do actions at specific time.

[IvoLeal72]

I know how to do that with java standard timers, I'm asking about the forge standard way, both for async and the clientside, how can I make it run client side

[SquidDev]

So what I'd normally do instead is you have some state on the pocket computer (either client-side or server side) which counts the number of ticks since the last "notify" call, and then drive the light colour based on that.

So something like this:

class PocketComputer { // PocketServerComputer on the server, or PocketComputerData on the client.
  private int notifyTimer = 0;

  public void notify() {
    notifyTimer = 60;
  }

  public void update() {
    if(notifyTimer > 0) notifyTimer--;
  }

  public int getLightColour() {
     var timer = notifyTimer / 12;
     return timer % 2 == 0 ? lightColour : 0x00CC00;
  }
}

The update() then would get called every tick (via Forge's TickEvent.ServerTickEvent/TickEvent.ClientTickEvent).

In order to do this on the client, you'd need to send a custom packet from the server to the client. This is a bit of a faff, so I probably wouldn't bother, and just do this server-side.

This would require making the original pocket.notify() method non-blocking, but I think that's fine.

[SquidDev]

Thank you for looking into this! The main thing stalling #1148 right now is that I'm not sure whether I actually want this feature (and if so, what the interface/functionality should be). I suspect the answer here is to go the #1406 route and add multiple upgrade slots, though that's blocked on a new Minecraft version.

Given the whole uncertainty around this, I'm afraid I'm going to close this.

[IvoLeal72]

Out of curiosity, why is it blocked on a new mc version? Breaking change?

[SquidDev]

Out of curiosity, why is it blocked on a new mc version? Breaking changes?

Yep! This'll require some changes to the Java API.