Rename "stroke" to "strokes" in motor product fields and views.

This update ensures consistency in field naming across models and views by using the plural form "strokes" to reflect its many-to-many relationship. The change improves clarity and aligns with naming conventions, reducing potential confusion for developers.
cbusillo · Jan 18, 2025 · 629318a · 629318a
1 parent 3da28cc
commit 629318a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/product_connect/models/motor.py b/product_connect/models/motor.py
@@ -442,7 +442,7 @@ def create_motor_products(self) -> None:
             current_product_ids = set(motor.products.ids)
 
             for product_template in product_templates:
-                if product_template.stroke and motor.stroke not in product_template.stroke:
+                if product_template.strokes and motor.stroke not in product_template.strokes:
                     continue
                 if product_template.configurations and motor.configuration not in product_template.configurations:
                     continue

diff --git a/product_connect/models/motor_product.py b/product_connect/models/motor_product.py
@@ -24,7 +24,7 @@ class MotorProductTemplate(models.Model):
 
     name = fields.Char(required=True)
 
-    stroke = fields.Many2many("motor.stroke")
+    strokes = fields.Many2many("motor.stroke")
     configurations = fields.Many2many("motor.configuration")
     manufacturers = fields.Many2many("product.manufacturer", domain=[("is_motor_manufacturer", "=", True)])
     excluded_by_parts = fields.Many2many("motor.part.template")

diff --git a/product_connect/views/motor_product_template_views.xml b/product_connect/views/motor_product_template_views.xml
@@ -10,7 +10,7 @@
                 <field name="part_type"/>
                 <field name="manufacturers" widget="many2many_tags"/>
                 <field name="configurations" widget="many2many_tags"/>
-                <field name="stroke" widget="many2many_tags"/>
+                <field name="strokes" widget="many2many_tags"/>
                 <field name="excluded_by_parts" widget="many2many_tags"/>
                 <field name="sequence"/>
             </list>