-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge-hanging corners in mesh #262
Merged
cburstedde
merged 28 commits into
cburstedde:develop
from
hannesbrandt:feature-mesh-hanging-corners
Dec 13, 2023
Merged
Edge-hanging corners in mesh #262
cburstedde
merged 28 commits into
cburstedde:develop
from
hannesbrandt:feature-mesh-hanging-corners
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburstedde
reviewed
Dec 7, 2023
cburstedde
reviewed
Dec 7, 2023
cburstedde
reviewed
Dec 7, 2023
cburstedde
reviewed
Dec 7, 2023
cburstedde
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p4est_mesh: add corner neighbors across coarse edges
Following up on issue #244 and the test proposed by @scottaiton in #235.
We introduce a
p4est_mesh_params_t
that contains all mesh-creation parameters with the possibility to add further parameters in the future. Thep4est_mesh_t
now contains ap4est_mesh_params_t
instance to store the parameters it was created with.In 3D, we add a new
edgehanging_corners
flag to the set of parameters. When set to true, quadrants that are corner neighbors across a coarse edge are stored in the same format as all other corner-neighbor relations of the mesh. If set to false, the mesh is created as usual.Furthermore, we add
p4est_mesh_new_params
which creates a mesh according to a passedp4est_mesh_params_t
instance. A default parameter instance can be created withp4est_mesh_params_new
and destroyed withp4est_mesh_params_destroy
.Apart from this, we remove a few unreachable lines of code in
mesh_iter_edge
and add some documentation inp4est_mesh.h
. Especially,p4est_mesh_get_neighbors
is now marked as outdated.