Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Publish to PyPI when releases are created on Github #75

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

rafaelcaricio
Copy link
Contributor

@rafaelcaricio rafaelcaricio commented Nov 5, 2020

Fixes #74

I've added a token that can publish to PyPI to the repository already.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files           2        2           
  Lines         141      141           
  Branches        8        8           
=======================================
  Hits          140      140           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1ac22...34e7d7f. Read the comment docs.

Copy link
Contributor

@allisonnicoledeal allisonnicoledeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the add of this! I think the readme might need to be updated too now, has old details

@rafaelcaricio
Copy link
Contributor Author

@allisonnicoledeal Updated! 💯

@rafaelcaricio rafaelcaricio merged commit ebed649 into master Nov 5, 2020
@rafaelcaricio rafaelcaricio deleted the automate-release branch November 5, 2020 18:32
@igorsobreira
Copy link

igorsobreira commented Nov 5, 2020

Nice setup, thanks @rafaelcaricio 👍

So we don't even need to create the tag ourselves anymore, Github Releases will create the tag for us which will trigger the action to push to pypi.

I noticed the version in Pypi is the same as our Releases. But our version in pyproject.toml is not updated. poetry version will update the pyproject.toml file, but that change happens when Github is running the action and it's never pushed. Would be nice to have that in sync, we don't ask poetry to bump the version automatically, we are specifically telling it the version we want, so the current behavior is not broken.

I created an issue to track this: #76

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Release on PyPI
3 participants