Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address DISCUSS from Murray Kucherawy's IESG review #27

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Address DISCUSS from Murray Kucherawy's IESG review #27

merged 1 commit into from
Oct 28, 2023

Conversation

cabo
Copy link
Contributor

@cabo cabo commented Oct 26, 2023

Replace "combination" by "requiring both"

@cabo cabo requested a review from henkbirkholz as a code owner October 26, 2023 15:21
@cabo cabo changed the title Address DISCUSS from Murray Mucherawy's IESG review Address DISCUSS from Murray Kucherawy's IESG review Oct 26, 2023
henkbirkholz
henkbirkholz approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cabo cabo merged commit c497fe2 into master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henkbirkholz henkbirkholz henkbirkholz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabo @henkbirkholz