Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using secret GPG_PASSPHRASE for improved security #565

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

mkarg
Copy link
Collaborator

@mkarg mkarg commented Aug 21, 2023

Description

This PR improves the security of our publication process by utilizing passphrases for GPG private keys by the Github Action.

Usage

In the Github security configuration, add a new GPG_PASSPHRASE secret, containing the passphrase of that secret key that you identified using the GPG_KEY_ID secret.

@mkarg mkarg requested a review from cbeust August 21, 2023 16:01
@mkarg mkarg self-assigned this Aug 21, 2023
@mkarg
Copy link
Collaborator Author

mkarg commented Aug 21, 2023

@cbeust I think it is a good idea if we improve security a bit by utilizing passphrases for GPG secret keys. The change works fine in my fork with a passphrase, but as you have not yet set a passphrase in your fork, you need to create the new secret GPG_PASSPHRASE in your repo's security settings, as I assume that Github Actions will fail if a referenced secret ID is not actually existing.

@mkarg mkarg merged commit 868e8dc into cbeust:master Sep 30, 2023
1 check passed
@mkarg
Copy link
Collaborator Author

mkarg commented Sep 30, 2023

@cbeust Merged after a four-weeks review period. I am assuming you have no objections. Please update GPG__PASSPHRASE in your Github security settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant