Fix leak of pages in restore_savepoint() #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages allocated in the system tree or freed tree when the savepoint was captured are currently leaked, because they are in a pending free state, and so do not appear in the diff of the allocator state, but they are also curretly being dropped from the freed tree. This fixes the leak, but make restore_savepoint() slower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages allocated in the system tree or freed tree when the savepoint was captured are currently leaked, because they are in a pending free state, and so do not appear in the diff of the allocator state, but they are also curretly being dropped from the freed tree.
This fixes the leak, but make restore_savepoint() slower