Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier setup: auto-detect tracker address if no config file found. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabacab
Copy link

@fabacab fabacab commented Jan 17, 2015

This commit adds a simple configuration file in PHP .ini syntax that
makes it easier to configure the tracker address and the database path.
The result is that no edits to the source code are required to use this.

This commit adds a simple configuration file in PHP `.ini` syntax that
makes it easier to configure the tracker address and the database path.
The result is that no edits to the source code are required to use this.
@cbdevnet
Copy link
Owner

Hi there, and thanks for your contribution!
I wanted to let you know I am aware of this PR, I'm just currently too busy to thoroughly review it.

The obvious benefit of reading config from the .ini file would, as you note, be that no edits to the code are needed and it can be excluded from the repository via gitignore.

Then again, I'd like to encourage as many people as possible to actually read the source code to find out what it is doing and confirm for themselves it is not doing anything it shouldn't.

I'll come back to this, and thanks again! :)

@fabacab
Copy link
Author

fabacab commented Jan 23, 2015

Cool, take your time. :)

In my humble opinion, people who want to confirm for themselves that the script is not doing anything malicious will read the source regardless of whether or not there is a config file and people who are not going to confirm this for themselves are also not going to do so regardless of the presence of a config file. However, there are also certainly a subset of people who would run this torrent IP checker if there was a config file but would not run this torrent IP checker if there was no way to do so without editing source.

And I would really like to see more people running independent IP checkers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants