Handle semver metadata in version string #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks whether the plugin correctly handles dependencies where the version contains a + character. The character is commonly used in semver version strings to add build metadata to the version. Per https://semver.org/ Currently this test fails as the plugin is comparing the following version strings that do not match: 7.2.27+33-04a1ea9e-SNAPSHOT 7.2.27%2B33-04a1ea9e-SNAPSHOT Reproduces: cb372#110
Update how version is parsed for pom files in the jar file to dependency logic to to cater for characters that are valid in version strings but encoded in the file path. For example, "+" which is used for semver metadata, encoded as "%2B". Before this change 7.2.27+33-04a1ea9e-SNAPSHOT version string was not handled consistently and would result in different values in the declared/used compile dependencies. Fixes: cb372#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update how version is parsed for pom files in the 'jar file to dependency' logic to cater for characters that are valid
in version strings but encoded in the file path.
For example,
"+"encoded as"%2B".The character is commonly used in semver version strings to add build metadata to the version. Per https://semver.org/
Why
Before this change
7.2.27+33-04a1ea9e-SNAPSHOTversion string was not handled consistently and would result in different values in the declared/used compile dependencies. This meant that the plugin was not usable for dependencies with build metadata in their version string.Fixes: #110