Kelvin-Voigt Boundary Implementation for #692 #710

cgeudeker · 2021-03-24T05:12:47Z

Describe the PR
Kelvin-Voigt boundary implementation for #692

Related Issues/PRs
This PR aims to implement the Kelvin-Voigt boundary, or more specifically the spring-dashpot system, as a boundary conditions. This utilizes linear elastic material properties, as added by PR #705, as well as json file input parameters (shown in the Additional context section) to calculate traction values for the following equations:

Spring coefficients kp and ks are calculated according to the following equations:

Other relevant to this PR, are the parameters delta, a and b. Each of these will be user input values under the boundary conditions as shown in the additional context section below. a and b are optional input parameters, which if not specified will be equivalent to a value of 1. However, the following relation must be satisfied:

where h_min is taken to be the cell height.

Additional context
input.json file is currently expected to look like the following

"boundary_conditions": {
...
   "absorbing_boundary": [
              {
                  "nset_id" : #,
                  "dir" : #,
                  "delta": #,
                  "a": #,
                  "b": #
              }
          ],
...
},

The above implementation is based on the work of this paper.

kks32

Add unit tests and please fix as per suggestions

include/io/io_mesh_ascii.h

include/io/io_mesh.h

include/io/io_mesh_ascii.tcc

include/loads_bcs/constraints.h

kks32 · 2021-03-24T11:00:21Z

include/node.tcc

+  auto mat_id = material_ids_.begin();
+
+  // Extract material properties and displacements
+  double pwave_v = this->property_handle_->property("pwave_velocity", prop_id_,


When do we map this information?

include/node.tcc

include/node.h

include/solvers/mpm_base.tcc

cgeudeker · 2021-03-25T05:00:54Z

I wasn't able to get the unit test done today, but I wanted to make sure that some of the other edits I was able to make today were what was expected since I was slightly unsure, particularly with regards to apply_absorbing_boundary. I also still wasn't quite sure where to map the new material information pwave_velocity and swave_velocity onto the nodal properties. I thought I had understood it to be in mpm_explicit.tcc but I couldn't find anything similar.

codecov · 2021-03-25T05:22:14Z

Codecov Report

Merging #710 (4cbc60a) into develop (adfe6f1) will decrease coverage by 0.12%.
The diff coverage is 86.44%.

@@             Coverage Diff             @@
##           develop     #710      +/-   ##
===========================================
- Coverage    96.75%   96.63%   -0.12%     
===========================================
  Files          130      131       +1     
  Lines        25932    26248     +316     
===========================================
+ Hits         25090    25363     +273     
- Misses         842      885      +43

Impacted Files	Coverage Δ
include/data_types.h	`66.67% <ø> (ø)`
include/loads_bcs/constraints.h	`100.00% <ø> (ø)`
include/mesh.h	`100.00% <ø> (ø)`
include/node.h	`100.00% <ø> (ø)`
include/node_base.h	`100.00% <ø> (ø)`
include/particles/particle.h	`100.00% <ø> (ø)`
include/particles/particle_base.h	`100.00% <ø> (ø)`
include/solvers/mpm_base.h	`50.00% <ø> (ø)`
include/solvers/mpm_scheme/mpm_scheme.tcc	`60.92% <0.00%> (-7.03%)`	⬇️
include/solvers/mpm_base.tcc	`73.63% <23.81%> (-3.41%)`	⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfe6f1...4cbc60a. Read the comment docs.

jgiven100 · 2021-03-25T17:33:52Z

@cgeudeker Would it work to follow along with nodal_velocity_constraints() in mpm_base.tcc here?

Within mpm_base it calls

constraints_->assign_nodal_velocity_constraints()

then in constraints.tcc it calls

mesh_->nodes(set_id)->assign_velocity_constraint()

at which point the velocity constaints are saved as nodal properties. For the absorbing boundary case, we would need to define 2 new variables in node.h to save the pwave and swave values.

cgeudeker · 2021-05-19T17:55:19Z

A few notes about the last commit.

I see that I need to put together a test case that will go through the absorbing constraint file, so I'll look at what was done for the others and follow along one of those. I'll probably commit this later today.

There is an issue that resurfaced while finalizing the test case for the mapping of wave velocities to nodes. When 2 particles of the same material were mapped to the nodes, the wave velocities doubled. I thought this would be fixed by having the update_property boolean argument set to false, but the same result occurred. So if there is any advice about how to best solve this it would be much appreciated.

Finally, some of the sections are poorly commented, so that will be fixed in the next couple of commits, but I wanted to make sure that the function was working as desired.

include/node.tcc

jgiven100 · 2021-08-12T23:05:46Z

@kks32 2 mains issues have come up. Guidance on these would be appreciated.

1: Nodal location affects how to go from traction -> force

Problem

The thesis provides an equation of traction for the absorbing boundary. We need to apply this as a nodal force. Based on the nodes location (corner, side, or bottom), the different components of the traction must be multiplied by either half or full cell lengths to become force. Below are the 3 cases to consider.

Proposed solution

Add "position" : to input JSON to indicate if the specific node set is for the model's "corner", "side", or "bottom". For example:

      "absorbing_constraints" : [
        { 
          "nset_id" : 0,
          "dir" : 1,
          "delta" : 0.25,
          "h_min" : 0.001,
          "a" : 1.0,
          "b" : 1.0,
          "position" : "corner"
        }
      ]

Then update apply_absorbing_constraint(...) to handle the 3 possible cases.

2: How to deal with material points displacing beyond the absorbing boundary

Problem

If delta is very small, then wave energy at the boundary will be reflected instead of absorbed. So delta must be somewhat large to be effective. But this also means that material points will likely displace beyond the absorbing boundary. If the mesh also extends beyond the absorbing boundary, the model will continue to run, but this breaks conservation of mass within the sub-domain defined by the absorbing boundary.

Is extending the mesh beyond the absorbing boundary an accetable work-around?
Is conservation of mass within the subdomain defined by the absorbing boundary necessary?
If extending mesh beyond the absorbing boundary is ok, would that affect the area of influence for going from traction to force (problem above)? (i.e., displacement and velocity will be mapped to the node form inside and outside the boundary, but the traction would still be only applied to the partial cell within the boundary.)

side note: I don't think Q3 is important for geotechnical applications, but rather for keeping the code general. Absorbing boundaries are likely to only be applied to the sides of models with lateral damping being a priority. Area of influence for lateral damping will be along vertical cell edges which wouldn't be affected by material points outside the absorbing boundary.

EDITS:

(Nov. 23, 2021): cross out wrong scheme

jgiven100 · 2021-08-19T15:49:16Z

@kks32 I've been able to locally implement the proposed solution described above (adding "position" to boundary inputs). I'll wait to hear from you if this is an acceptable solution before pushing to the feature branch.

kks32 · 2021-08-19T15:53:31Z

@jgiven100 That's a good solution. Thanks!!

include/loads_bcs/absorbing_constraint.h

jgiven100 · 2021-08-19T18:38:51Z

@kks Seems like there might have been a Clang update? Clang is failing here. Seems to have been passing before.

kks32 · 2021-08-19T20:39:52Z

@kks Seems like there might have been a Clang update? Clang is failing here. Seems to have been passing before.

I thought it was cppcheck not clang:

include/node.tcc:404:37: warning: Found suspicious operator ',' [constStatement]
            absorbing_force_ << dir0, dir1;
                                    ^
include/node.tcc:409:37: warning: Found suspicious operator ',' [constStatement]
            absorbing_force_ << dir0, dir1;

You can turn-off clang-format temporarily using

    // clang-format off
    ...code...
    // clang-format on

include/node.tcc

jgiven100 · 2021-11-23T18:00:46Z

@kks32 @cgeudeker

Feature Updates

I've locally updated node.tcc to handle 3D models.

Verification

With a 3D column, I've been able to reproduce 1D p-wave results (from Al-Kafaji thesis).
I'll work on upward moving shear wave next. Once reproducing the 2D results, I'll push changes here (next few days).

Next Steps

Current 2D benchmark Kelvin-Voigt Boundary Benchmark Case mpm-benchmarks#20 needs some slight updates due to changes in input file naming convention.
Add identical 3D benchmark to the above open bencmark PR.
Open mpm-doc PR.

Edits

(24 Nov. 2021) - make next steps into check boxes

jgiven100 · 2021-11-25T22:29:50Z

@kks @cgeudeker
This is ready for a re-review.

I'm happy with unit testing coverage for 18 of 21 changed files. Expections are mpm_base.tcc, mpm_scheme.tcc, and mpm_explicit.tcc. Looking at similar existing functions for the exception files, I don't see too much existing testing... This leads me to believe that the areas with low coverage in this update is ok.

Kelvin-Voight Boundary Condition Implementation

9c73b25

kks32 requested review from kks32 and jgiven100 March 24, 2021 10:26

kks32 self-assigned this Mar 24, 2021

kks32 added Priority: Medium Status: Review needed Type: Core feature labels Mar 24, 2021

kks32 requested changes Mar 24, 2021

View reviewed changes

cgeudeker and others added 2 commits March 24, 2021 21:51

First Edits, and absorbing constraint file

55d7b19

Merge branch 'develop' into material

97e282d

cgeudeker added 3 commits May 18, 2021 22:06

Test cases

e1d24ce

Test cases

d61aafa

Test cases, minor fix

e30d186

cgeudeker added 4 commits May 24, 2021 20:59

Test Case for Absorbing Constraint File

6a53280

Minor Fixes

04380c3

Switched Assert for If Statement

4999748

Absorbing Boundary in Scheme

e1ccc53

cgeudeker mentioned this pull request Aug 4, 2021

Kelvin-Voigt Boundary Benchmark Case cb-geo/mpm-benchmarks#20

Open

jgiven100 reviewed Aug 11, 2021

View reviewed changes

include/node.tcc Outdated Show resolved Hide resolved

jgiven100 reviewed Aug 11, 2021

View reviewed changes

include/node.tcc Outdated Show resolved Hide resolved

Merge branch 'develop' of https://github.com/cb-geo/mpm into material

f082fbf

jgiven100 added 2 commits August 19, 2021 11:09

🔨 add position input to absorb boundary

fe5f74e

🔨🔥 remove unused variables

472fce5

kks32 requested changes Aug 19, 2021

View reviewed changes

include/loads_bcs/absorbing_constraint.h Outdated Show resolved Hide resolved

jgiven100 added 3 commits August 19, 2021 14:39

🔨 change absorb bound position from string to enum

f3b70e6

🎯✔️ update absorb boundary tests

fd06771

🔨🐛 replace if with switch statement and cppcheck suppress

f5f2d1b

jgiven100 reviewed Sep 4, 2021

View reviewed changes

include/node.tcc Outdated Show resolved Hide resolved

🐛🔨 fix traction -> force for absorb boundary

805626c

jgiven100 self-assigned this Nov 24, 2021

jgiven100 added 6 commits November 23, 2021 16:11

Merge branch 'develop' of https://github.com/cb-geo/mpm into material

1e3e479

🔧✨ add 3d support for Kelvin-Voigt

229e1d7

🚧🎯 improve test coverage

746283d

🐛 clang-format

397e6e9

🚧🎯 improve test coverage

6fa65b9

🎯🔥 tidy commented-out lines

4cbc60a

jgiven100 mentioned this pull request Nov 25, 2021

🎉📝 add absorbing constraint details to input cb-geo/mpm-doc#64

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kelvin-Voigt Boundary Implementation for #692 #710

Kelvin-Voigt Boundary Implementation for #692 #710

cgeudeker commented Mar 24, 2021

kks32 left a comment

kks32 Mar 24, 2021

cgeudeker commented Mar 25, 2021

codecov bot commented Mar 25, 2021 •

edited

Loading

jgiven100 commented Mar 25, 2021 •

edited

Loading

cgeudeker commented May 19, 2021

jgiven100 commented Aug 12, 2021 •

edited

Loading

jgiven100 commented Aug 19, 2021

kks32 commented Aug 19, 2021

jgiven100 commented Aug 19, 2021

kks32 commented Aug 19, 2021

jgiven100 commented Nov 23, 2021 •

edited

Loading

jgiven100 commented Nov 25, 2021 •

edited

Loading

Kelvin-Voigt Boundary Implementation for #692 #710

Are you sure you want to change the base?

Kelvin-Voigt Boundary Implementation for #692 #710

Conversation

cgeudeker commented Mar 24, 2021

kks32 left a comment

Choose a reason for hiding this comment

kks32 Mar 24, 2021

Choose a reason for hiding this comment

cgeudeker commented Mar 25, 2021

codecov bot commented Mar 25, 2021 • edited Loading

Codecov Report

jgiven100 commented Mar 25, 2021 • edited Loading

cgeudeker commented May 19, 2021

jgiven100 commented Aug 12, 2021 • edited Loading

1: Nodal location affects how to go from traction -> force

Problem

Proposed solution

2: How to deal with material points displacing beyond the absorbing boundary

Problem

EDITS:

jgiven100 commented Aug 19, 2021

kks32 commented Aug 19, 2021

jgiven100 commented Aug 19, 2021

kks32 commented Aug 19, 2021

jgiven100 commented Nov 23, 2021 • edited Loading

Feature Updates

Verification

Next Steps

Edits

jgiven100 commented Nov 25, 2021 • edited Loading

codecov bot commented Mar 25, 2021 •

edited

Loading

jgiven100 commented Mar 25, 2021 •

edited

Loading

jgiven100 commented Aug 12, 2021 •

edited

Loading

jgiven100 commented Nov 23, 2021 •

edited

Loading

jgiven100 commented Nov 25, 2021 •

edited

Loading