Skip to content

HelpersTask622_gitleaks_doesnt_run_in_submodules_2 #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 13, 2025
Merged

HelpersTask622_gitleaks_doesnt_run_in_submodules_2 #664

merged 17 commits into from
May 13, 2025

Conversation

heanhsok
Copy link
Contributor

@heanhsok heanhsok commented May 5, 2025

Task #622

  • Move gitleaks rule from .github to dev_scripts_helpers/git/gitleaks so it can be pointed to from both the GH actions and the git hooks without creating symlinks

heanhsok added 2 commits May 5, 2025 16:21
@heanhsok
Checkpoint
f9c3e3f 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Checkpoint
570f415 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok heanhsok self-assigned this May 5, 2025
heanhsok added 4 commits May 5, 2025 18:06
@heanhsok
Checkpoint
fba1e01 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Merge branch 'master' into HelpersTask622_gitleaks_doesnt_run_in_subm…
fcfdca0 
…odules_2
@heanhsok
Checkpoint
8329034 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Merge branch 'HelpersTask622_gitleaks_doesnt_run_in_submodules_2' of …
51cd5d5 
…github.com:causify-ai/helpers into HelpersTask622_gitleaks_doesnt_run_in_submodules_2

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok heanhsok marked this pull request as draft May 5, 2025 18:23
heanhsok
heanhsok commented May 5, 2025
View reviewed changes
@heanhsok heanhsok added the PR for reviewers The PR needs to be reviewed by RPs label May 5, 2025
@heanhsok heanhsok requested a review from gpsaggese May 5, 2025 20:55
heanhsok added 2 commits May 6, 2025 01:00
@heanhsok
Lint
001cb70 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Merge branch 'master' into HelpersTask622_gitleaks_doesnt_run_in_subm…
eb81c23 
…odules_2
@heanhsok heanhsok marked this pull request as ready for review May 7, 2025 23:53
@gpsaggese gpsaggese requested a review from Copilot May 8, 2025 20:11
Copilot
Copilot AI reviewed May 8, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the gitleaks configuration from the .github directory into dev_scripts_helpers/git/gitleaks so that it can be referenced by both GitHub Actions and git hooks without relying on symlinks.

  • Refactored the check_gitleaks function in utils.py to compute repository paths using the new hgit helpers.
  • Updated the GitHub Actions workflow to point to the new gitleaks configuration file path.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
dev_scripts_helpers/git/git_hooks/utils.py Removed get_git_root_dir and updated check_gitleaks to compute and use the new config path
.github/workflows/gitleaks.yml Updated GITLEAKS_CONFIG to reference the new location of the gitleaks configuration file
Comments suppressed due to low confidence (1)

dev_scripts_helpers/git/git_hooks/utils.py:482

  • [nitpick] Consider adding an inline comment to explain the rationale behind concatenating '/app' with the relative helpers root to form the config path, which would help future maintainers understand the docker mount configuration.
config_path = os.path.join("/app", rel_path, "dev_scripts_helpers/git/gitleaks")

heanhsok added 8 commits May 13, 2025 18:29
@heanhsok
Checkpoint
074a5fc 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Merge branch 'master' into HelpersTask622_gitleaks_doesnt_run_in_subm…
2101e95 
…odules_2
@heanhsok
Checkpoint
5e98522 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Checkpoint
874b702 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Merge branch 'HelpersTask622_gitleaks_doesnt_run_in_submodules_2' of …
6133dd3 
…github.com:causify-ai/helpers into HelpersTask622_gitleaks_doesnt_run_in_submodules_2

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Add comment
84e5df1 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Checkpoint
c83a53f 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok
Nit
4fea3b8 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@heanhsok heanhsok enabled auto-merge (squash) May 13, 2025 18:56
@heanhsok heanhsok merged commit d193c41 into master May 13, 2025
4 checks passed
@heanhsok heanhsok deleted the HelpersTask622_gitleaks_doesnt_run_in_submodules_2 branch May 13, 2025 18:58
@heanhsok heanhsok mentioned this pull request May 13, 2025
Closed
heanhsok added a commit to heanhsok/helpers that referenced this pull request Jun 5, 2025
@heanhsok
HelpersTask622_gitleaks_doesnt_run_in_submodules_2 (causify-ai#664)
f99917d 
* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Lint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Add comment

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Nit

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
heanhsok added a commit to heanhsok/helpers that referenced this pull request Jun 5, 2025
@heanhsok
HelpersTask622_gitleaks_doesnt_run_in_submodules_2 (causify-ai#664)
7e61cf5 
* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Lint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Add comment

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Checkpoint

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅

* Nit

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gpsaggese gpsaggese Awaiting requested review from gpsaggese

Assignees

@heanhsok heanhsok

Labels
PR for reviewers The PR needs to be reviewed by RPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heanhsok @gpsaggese