Skip to content

HelpersTask615_Come_up_with_a_testing_approach_for_release_flow #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 12, 2025
Merged

HelpersTask615_Come_up_with_a_testing_approach_for_release_flow #651

merged 29 commits into from
May 12, 2025

Conversation

sandeepthalapanane
Copy link
Collaborator

Addressing #615

Added unit tests for docker_build_prod_image (both single arch and multi-arch)

sandeepthalapanane and others added 22 commits April 28, 2025 19:59
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
053175a 
…_up_with_a_testing_approach_for_release_flow

No pre-commit output found.
@sandeepthalapanane
HelpersTask615: Add unittest for docker_build_local_image()
0193193 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
7bb1e74 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Modify comments and docstring
070c1c1 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Move helper functions out of the class
62e1f7e 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
98ff6cc 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Merge master
bbc022b 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Rename helper functions
3dc176b 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Merge master into HelpersTask615_Come_up_with_a_testi…
1d66e48 
…ng_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@dremdem
Merge branch 'master' into HelpersTask615_Come_up_with_a_testing_appr…
0b78a4d 
…oach_for_release_flow
@sandeepthalapanane
HelpersTask615: Split the check into seperate checks
49c5841 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
aec4479 
…_up_with_a_testing_approach_for_release_flow

No pre-commit output found.
@sandeepthalapanane
HelpersTask615: Remove .body from function call
1da532a 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
c408886 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Update
e61b802 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Propogate changes from previous commit
1781088 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
939dc32 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Modify comments
aa08a68 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@gpsaggese
Merge branch 'master' into HelpersTask615_Come_up_with_a_testing_appr…
45a2113 
…oach_for_release_flow
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
3e9ac1d 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
HelpersTask615: Added tests for building prod_image
e545fcc 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
649a946 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane sandeepthalapanane self-assigned this May 2, 2025
gpsaggese
gpsaggese reviewed May 4, 2025
View reviewed changes
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction, but the amount of copy-paste gives the reader headache.

There are some chunks of code that have a clear meaning and should be factored out
Let's factor them out.

dremdem
dremdem reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just couple nits.

@sandeepthalapanane
HelpersTask615: Add a helper test class to refactor common code
fa46cc3 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
dremdem
dremdem reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress.
Some comments.

@sandeepthalapanane
HelpersTask615: Move inputs into setUp
816c2da 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane sandeepthalapanane requested a review from dremdem May 5, 2025 17:01
dremdem
dremdem approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sandeepthalapanane and others added 3 commits May 5, 2025 14:35
@sandeepthalapanane
HelpersTask615: Change setUp and tearDown
6fdf6bf 
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge remote-tracking branch 'origin/master' into HelpersTask615_Come…
6fc4738 
…_up_with_a_testing_approach_for_release_flow

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@sandeepthalapanane
Merge branch 'master' into HelpersTask615_Come_up_with_a_testing_appr…
457b863 
…oach_for_release_flow
@sandeepthalapanane sandeepthalapanane added the PR for reviewers The PR needs to be reviewed by RPs label May 7, 2025
@sandeepthalapanane
Copy link
Collaborator Author

sandeepthalapanane commented May 8, 2025 •
edited
Loading

@gpsaggese I have completed creating tests for almost all the functions in lib_tasks_docker_release.py. Would you like to push these tests in this PR itself or create a separate PR after merging this one?

gpsaggese
gpsaggese reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@gpsaggese gpsaggese merged commit 87b9972 into master May 12, 2025
4 checks passed
@gpsaggese gpsaggese deleted the HelpersTask615_Come_up_with_a_testing_approach_for_release_flow branch May 12, 2025 15:48
@gpsaggese
Copy link
Contributor

@gpsaggese I have completed creating tests for almost all the functions in lib_tasks_docker_release.py. Would you like to push these tests in this PR itself or create a separate PR after merging this one?

Sorry I didn't see this. When you are blocked just send me a ping email with the PR to review, etc.

Yes, now let's test all the ones we can test. We don't want to overtest, so if you want you can create a test plan for us to review.

@sandeepthalapanane sandeepthalapanane restored the HelpersTask615_Come_up_with_a_testing_approach_for_release_flow branch May 12, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsaggese gpsaggese gpsaggese left review comments

@dremdem dremdem dremdem approved these changes

@sonniki sonniki Awaiting requested review from sonniki

@samarth9008 samarth9008 Awaiting requested review from samarth9008

Assignees

@sandeepthalapanane sandeepthalapanane

Labels
PR for reviewers The PR needs to be reviewed by RPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeepthalapanane @gpsaggese @dremdem