Skip to content

HelpersTask616_Document_coverage_with_Codecov #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 8, 2025

Conversation

Shaunak01
Copy link
Collaborator

Issue: #616

@Shaunak01 Shaunak01 self-assigned this Apr 28, 2025
@Shaunak01 Shaunak01 requested review from dremdem and gpsaggese April 29, 2025 00:26
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.
Some comments.

@Shaunak01 Shaunak01 requested a review from dremdem May 1, 2025 01:40
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
Just some nits.

Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Ok to merge for me

Shaunak01 added 2 commits May 1, 2025 17:50
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@Shaunak01 Shaunak01 requested a review from dremdem May 1, 2025 18:04
Copy link
Contributor

@dremdem dremdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just one nit, and we're done.
Feel free to request a review from Samarth after addressing it.

Shaunak01 added 2 commits May 1, 2025 22:26
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
…b.com:causify-ai/helpers into HelpersTask616_Document_coverage_with_Codecov

Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@Shaunak01 Shaunak01 requested a review from gpsaggese May 6, 2025 13:06
Pre-commit checks:
- 'check_master' passed
- 'check_author' passed
- 'check_file_size' passed
- 'check_python_compile' passed
- 'check_gitleaks' passed
All checks passed ✅
@Shaunak01 Shaunak01 requested a review from gpsaggese May 7, 2025 15:19
@gpsaggese gpsaggese merged commit fa7b10d into master May 8, 2025
4 checks passed
@gpsaggese gpsaggese deleted the HelpersTask616_Document_coverage_with_Codecov branch May 8, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants