Zoltan/defining default allocation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves cauldron#22 - The issue here is that bd.projects.get_base_directories() will return a Path object which cannot be serialized. We can address this by simply converting it to a string before saving it out. ===== TESTS ====== I tested by ensuring my local copy of AB would boot up without issues. Prior to this, I was getting errors about the json file not being readable or writable with json.load or json.dump
…tings-is-invalid app will crash if settings is invalid
- sorting after changing a def alloc field does not always work automatically (sorting column and order is reset by the update_proxy_model() call) - checking the read-only checkboxes sometimes triggers a reorder of the table (probably because of the sync() call) - application crashes when flushing the databases (even without changes), because flush() triggers a sync(), which does not call begin / end ModelReset()
Pull Request Test Coverage Report for Build 10628628341Details
💛 - Coveralls |
- on the read-only flag: here we expect clicks to toggle the flag - on the default allocation column, when the database is not read-only: in this case we expect the item editor for the cell to open
createIndex(row, col) only works with QTableView and with no proxy model, in all these cases index is the correct method to call.
|
@zoltanszocs This is good progress! The double-click to change database default allocation is definitely not intuitive, but I don't think we need to worry about that right now. I updated #33 with more detail on the remaining tasks.
This is blocked by brightway-lca/multifunctional#23
I don't see the allocation values, not sure where the bug is. According to the tests this information is being stored correctly? |
For not multifunctional db: - default allocatin can not be edited now - its value is "Not applicable"
…-browser into zoltan/defining-default-allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog.