Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable prettier for vscode users #200

Closed
wants to merge 1 commit into from

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Jul 5, 2024

The conflict between Prettier and ESLint Stylistic was causing a lot of errors!

@prazdevs
Copy link
Member

prazdevs commented Jul 6, 2024

I dont think VSC settings belong in a github repository. Maybe specify in the readme or contributing that style is handled by ESLint and it is recommended to use it instead of whatever tool.

@uncenter
Copy link
Member Author

uncenter commented Jul 6, 2024

I dont think VSC settings belong in a github repository

You already have https://github.com/catppuccin/vscode-icons/blob/main/.vscode/launch.json and the entire point of being able to have a repository-specific .vscode/settings.json is for stuff like this.

Maybe specify in the readme or contributing that style is handled by ESLint and it is recommended to use it instead of whatever tool.

Hmm well then I'll just have to keep this file floating around untracked anyway to disable Prettier. FYI you can also use this file to turn on ESLint autofix on save, and more.

@uncenter uncenter closed this Jul 6, 2024
@prazdevs
Copy link
Member

prazdevs commented Jul 6, 2024

the launch is for the debugger and is independant of whatever config/extensions people are using.
could always add the settings.json to the gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants