refactor(scripts): split icons.ts & add new commands
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage.json#scripts entries
|
The diff is awful, as usual. I haven't changed a single line of code besides copying the original script into each file, removing the unrelated functions and function declaration wrapper, and removing unused imports. |
sgoudham
reviewed
Aug 8, 2024
sgoudham
approved these changes
Aug 8, 2024
sgoudham
changed the title
icons.ts & add new commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that having to use CLI flags was frustrating and it makes more sense to me at least to split each function into a separate file and run it as a separate script. I have done just that in this PR, and also recreated the
icons --allbehavior withpnpm run icons, which uses pnpm's support for multiple scripts / regex to run all theicons:subscripts.