Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm chart install & template prototype #98

Merged
merged 13 commits into from
Mar 18, 2024
Merged

Conversation

kidneyweakx
Copy link
Collaborator

@kidneyweakx kidneyweakx commented Jan 12, 2024

PULL REQUEST

Before

說明 (Description)

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: macOS 14.2.1
  • NodeJS Version: 9.8.1
  • NPM Version: 18.18.2
  • Docker Version: 24.0.6

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單,並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)

@kidneyweakx
Copy link
Collaborator Author

plan to support Kubernetes and helm chart in this PR

@kidneyweakx kidneyweakx self-assigned this Jan 12, 2024
Base automatically changed from 2.1.0 to master February 2, 2024 08:51
feat: cluster ts

feat: helm charts install & template prototype
@kidneyweakx kidneyweakx changed the base branch from master to 3.0.0 February 2, 2024 09:18
@kidneyweakx kidneyweakx marked this pull request as ready for review March 5, 2024 08:03
@Pianochicken Pianochicken deleted the branch 3.0.0 March 7, 2024 01:51
@kidneyweakx kidneyweakx reopened this Mar 7, 2024

export const builder = (yargs: Argv<OptType>) => {
return yargs
.example('bdk quorum cluster create --interactive', 'Cathay BDK 互動式問答')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bdk quorum cluster apply

const confirmDelete = (await prompts({
type: 'confirm',
name: 'value',
message: '⚠️ Detecting quorum nodes already exists. The following processes will remove all existing files. Continue?',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quorum cluster

initial: false,
}, { onCancel })).value
if (confirmDelete) {
const spinner = ora('Quorum Network Create ...').start()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quorum Cluster Delete...

})()
const spinner = ora('Quorum Network Import ...').start()
await cluster.apply(networkCreate, spinner)
spinner.succeed('Quorum Network Import Successfully!')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const spinner = ora('Quorum Cluster Apply ...').start()
await cluster.apply(clusterApply, spinner)
spinner.succeed('Quorum Cluster Apply Successfully!')

src/quorum/command/cluster/delete.ts Show resolved Hide resolved
}
})()

const spinner = ora('Quorum Network Import ...').start()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const spinner = ora('Quorum Cluster Generate ...').start()


const spinner = ora('Quorum Network Import ...').start()
await cluster.generate(clusterGenerate, networkCreate)
spinner.succeed('Quorum Network Import Successfully!')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinner.succeed('Quorum Cluster Generate Successfully!')

public async delete (): Promise<void> {
const k8s = new KubernetesInstance(this.config, this.infra, this.kubernetesInfra)
const releases = await this.getAllHelmRelease()
releases.forEach(async (release: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await Promise.all(releases.map(async (release: string) => {
      await k8s.delete({ name: release, namespace: 'quorum' })
    }))

這邊改成這樣比較好,外面的 ✔ Quorum Cluster Delete Successfully! 也不會提前跳出,刪除速度也會比較快

@kidneyweakx kidneyweakx merged commit a49479f into 3.0.0 Mar 18, 2024
1 check passed
@kidneyweakx kidneyweakx deleted the feat/helmTemplate branch March 18, 2024 09:32
@kidneyweakx kidneyweakx mentioned this pull request Mar 19, 2024
14 tasks
Pianochicken pushed a commit that referenced this pull request Mar 19, 2024
* feat: helm chart install & template prototype (#98)

* feat: helm chart install & template prototype

feat: cluster ts

feat: helm charts install & template prototype

* feat(helm): create basic helm chart

* feat(helm): helm install in infra

* feat(bdk): bdk cluster apply network

* feat(bdk): bdk cluster generate network

* fix: generate yaml issues

* feat(helm): cloud native helm config

* feat(helm): aws region choice

* feat(helm): bdk network migrate with loadbalancer

* feat(bdk): bdk quorum cluster delete network

* docs(cluster): write cluster docs

* chore: fix command typo and wrong example

* fix: cluster generate template func

* chore: update version and LICENSE

* fix: unit test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants