feat: bootnode mode #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinXJ1204
requested review from
kth-tw,
Pianochicken and
kidneyweakx
as code owners
|
List Test Configuration like this: |
kidneyweakx
reviewed
Jan 12, 2024
kidneyweakx
reviewed
Jan 12, 2024
| @@ -20,7 +20,7 @@ class ValidatorDockerComposeYaml extends DockerComposeYaml { | |||
| volumes: [`${bdkPath}/validator${validatorNum}/data/:/data`], | |||
| entrypoint: [ | |||
| '/bin/sh', '-c', | |||
| `geth init --datadir /data /data/genesis.json; geth --datadir /data --networkid ${chainId} --nodiscover --verbosity 3 --syncmode full --nousb --mine --miner.threads 1 --miner.gasprice 0 --emitcheckpoints --http --http.addr 0.0.0.0 --http.port 8545 --http.corsdomain "*" --http.vhosts "*" --ws --ws.addr 0.0.0.0 --ws.port 8546 --ws.origins "*" --http.api admin,trace,db,eth,debug,miner,net,shh,txpool,personal,web3,quorum,istanbul,qbft --ws.api admin,trace,db,eth,debug,miner,net,shh,txpool,personal,web3,quorum,istanbul,qbft --port ${peerPort} `, | |||
| `geth init --datadir /data /data/genesis.json; geth --datadir /data --networkid ${chainId} --verbosity 3 --syncmode full --nousb --mine --miner.threads 1 --miner.gasprice 0 --emitcheckpoints --http --http.addr 0.0.0.0 --http.port 8545 --http.corsdomain "*" ${(bootnode) ? '--bootnodes '.concat(nodeEncode) : ''} --http.vhosts "*" --ws --ws.addr 0.0.0.0 --ws.port 8546 --ws.origins "*" --http.api admin,trace,db,eth,debug,miner,net,shh,txpool,personal,web3,quorum,istanbul,qbft --ws.api admin,trace,db,eth,debug,miner,net,shh,txpool,personal,web3,quorum,istanbul,qbft --port ${peerPort} `, | |||
There was a problem hiding this comment.
after delete nodiscover, is it still comply with static node standard?
and we should make this entrypoint more beautiful
There was a problem hiding this comment.
There was a problem hiding this comment.
${(bootnode) ? '--bootnodes '.concat(nodeEncode) : '--nodiscover'}
kidneyweakx
reviewed
Jan 12, 2024
src/quorum/command/network/create.ts
Outdated
Comment on lines
123
to
125
| Object.values(isbootNodeList).forEach((item: any) => { | ||
| item.forEach((node: any) => { | ||
| bootNodeList[node] = true |
There was a problem hiding this comment.
use flat() to save a foreach loop
Object.values(isbootNodeList).flat().forEach(node => {
bootNodeList[node] = true
})
kidneyweakx
reviewed
Jan 12, 2024
src/quorum/command/network/create.ts
Outdated
Comment on lines
96
to
112
| const nodelist = [] | ||
| for (let i = 0; i < validatorNumber; i += 1) { | ||
| nodelist.push( | ||
| { | ||
| title: `validator${i}`, | ||
| value: `${i}`, | ||
| }, | ||
| ) | ||
| } | ||
| for (let i = 0; i < memberNumber; i += 1) { | ||
| nodelist.push( | ||
| { | ||
| title: `member${i}`, | ||
| value: `${i + validatorNumber}`, | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think nodelist use Array.from() can much more prettier?
const createNode = (type: string, index: number, offset = 0) => ({
title: `${type}${index}`,
value: `${index + offset}`,
})
const nodelist = [
...Array.from({ length: validatorNumber }, (_, i) => createNode('validator', i)),
...Array.from({ length: memberNumber }, (_, i) => createNode('member', i, validatorNumber)),
]
kidneyweakx
reviewed
Jan 12, 2024
kidneyweakx
reviewed
Jan 12, 2024
| @@ -18,6 +18,8 @@ export interface NetworkCreateType { | |||
| validatorNumber: number | |||
| memberNumber: number | |||
| alloc: AllocType[] | |||
| isBootNode: boolean | |||
| bootNodeList: any[] | |||
There was a problem hiding this comment.
bootNodeList: any[] -> boolean[]
kidneyweakx
approved these changes
Jan 17, 2024
14 tasks
Pianochicken
added a commit
that referenced
this pull request
Feb 2, 2024
* refactor: replace all then to promise (#96) * feat: bootnode mode (#97) * feat: bootnode mode * feat: assign specified node to be bootnode * fix: remove console log * fix: eslink and test * fix: adjust for pr comments * feat: optimize create network process (#100) * feat: transform bdk ui to quorum dashboard (#99) * feat: bdk ui dashboard * fix: modify reviewed code * fix(ui): network info json location --------- Co-authored-by: kidneyweak <[email protected]> * fix: modify ui to dashboard (#101) * update: 2.1.0 bdk dashboard * fix(ca): promise catch test error (#103) --------- Co-authored-by: Chengwei-Lin <[email protected]> Co-authored-by: JakeKuo <[email protected]> Co-authored-by: PianoChicken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Before
說明 (Description)
相關問題 (Linked Issues)
貢獻種類 (Type of change)
測試環境 (Test Configuration):
檢查清單 (Checklist):
我已完成以上清單，並且同意遵守 Code of Conduct
I have completed the checklist and agree to abide by the code of conduct.