feat: update existing comment #51
Open
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkan-ozal
reviewed
Feb 17, 2024
bojanrajh
force-pushed
the
feat/update-existing-comment
branch
from
7655e4e
to
be91765
Compare
serkan-ozal
approved these changes
Mar 2, 2024
|
@bojanrajh Look good to me. |
serkan-ozal
approved these changes
Mar 2, 2024
|
@bojanrajh Could you please check style issues by |
|
@serkan-ozal Done. |
|
Thank you @bojanrajh for the PR. Can you please fix the CI check and run Is it also possible to provide an example workflow run to show that the update comment flow works as expected? |
geekgonecrazy
added a commit
to RocketChat/Rocket.Chat
that referenced
this pull request
Apr 2, 2024
d-gubert
added a commit
to RocketChat/Rocket.Chat
that referenced
this pull request
Apr 12, 2024
commit 0c93266 Merge: 7aa3136 0fcf1f0 Author: Aaron Ogle <[email protected]> Date: Wed Apr 3 16:59:34 2024 +0000 Merge branch 'develop' into add-metrics-to-actions commit 7aa3136 Merge: e71dc83 fa9c905 Author: Guilherme Gazzo <[email protected]> Date: Tue Apr 2 23:41:33 2024 -0300 Merge branch 'develop' into add-metrics-to-actions commit e71dc83 Author: Aaron Ogle <[email protected]> Date: Tue Apr 2 16:43:25 2024 +0000 Add to the two heavy meteor build jobs for some visibility commit 9d3f6b3 Author: Aaron Ogle <[email protected]> Date: Tue Apr 2 16:33:15 2024 +0000 helps if put in the actual workflow. Its not even Monday o.o commit c045379 Author: Aaron Ogle <[email protected]> Date: Tue Apr 2 16:18:27 2024 +0000 setting comment_on_pr to false until catchpoint/workflow-telemetry-action#51 is merged commit 7d52dc9 Author: Aaron Ogle <[email protected]> Date: Tue Apr 2 16:13:06 2024 +0000 Add telemetry to CI so we can get a better understanding of resource usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
comment_on_pr=updateoption and closes #48 .