Fix EC2 instance lifecycle #1624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that EC2 instances are correctly set to offline before being shutdown. I notice multiples bugs on this logic : - EC2 instances flagged as offline was receiving tests (fix in getwork.php) - Offline EC2 instances was not correctly reset to online when the server requires more machines (fix in ec2.inc.php on GetTesters call - The server was terminated EC2 instances that was not offline. - ping.php was wrongly resetting the « last work » timestamp and was blocking EC2 shutdown.
|
Hello, do you need more information to evaluate this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that EC2 instances are correctly set to offline before being shutdown.
I notice multiples bugs on this logic :