Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox log parser #667

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Fix Firefox log parser #667

merged 5 commits into from
Aug 13, 2024

Conversation

lbartoli79
Copy link
Contributor

@lbartoli79 lbartoli79 commented Aug 6, 2024

This fixes Firefox log parser and add support for latest selenium:

Before:
image

After:
image

elif msg['message'].startswith('nsSocketTransport::SendStatus '):
match = re.search(r'^nsSocketTransport::SendStatus \['
r'this=(?P<socket>[\w\d]+) '
r'status=(?P<status>[\w\d]+)', msg['message'])
if match:
socket = match.groupdict().get('socket')
status = match.groupdict().get('status')
if status == '804b0007':
if status in ['804b0007', '4b0007']:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claud-io claud-io marked this pull request as ready for review August 6, 2024 15:20
@claud-io claud-io requested a review from pmeenan August 7, 2024 14:11
Copy link
Contributor

@pmeenan pmeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume it is intended, but the OCSP pref change will be a behavior change and the OCSP time for non-stapled origins will be hidden after the change.

@lbartoli79 lbartoli79 merged commit a6a7b82 into master Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants