Closing issue #2312 #2942
Open
Closing issue #2312 #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created docs of Clara inside, fixing issue catchorg#2312
updated Clara docs with link to new docs inside the catch documentation itself. Fixing issue catchorg#2312
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2942 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 198 198
Lines 8597 8597
=======================================
Hits 7822 7822
Misses 775 775 |
horenmar
reviewed
Dec 16, 2024
| @@ -110,7 +110,7 @@ int main( int argc, char* argv[] ) { | |||
| } | |||
| ``` | |||
|
|
|||
| See the [Clara documentation](https://github.com/catchorg/Clara/blob/master/README.md) | |||
| See the [Clara documentation](https://github.com/irvincardoza/Catch2/blob/devel/docs/Clara.md) | |||
There was a problem hiding this comment.
This link is reliant on your fork. Instead, it should be using relative reference to the new file.
horenmar
reviewed
Dec 16, 2024
Comment on lines
+2
to
+4
| [](https://travis-ci.org/catchorg/Clara) | ||
| [](https://ci.appveyor.com/project/catchorg/clara) | ||
| [](https://codecov.io/gh/catchorg/Clara) |
There was a problem hiding this comment.
These are all irrelevant to the version embedded into the repo, as it is not built or tested separately.
horenmar
reviewed
Dec 16, 2024
Comment on lines
+11
to
+13
| Clara is a single-header library. | ||
|
|
||
| To use, just `#include "clara.hpp"` |
There was a problem hiding this comment.
No longer true for the embedded version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Clara Documentation inside the Catch2 docs. Also updated the link in the own-main docs to point to the new Clara docs