Improve test-naming abilities for parameterized tests #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2771 +/- ##
==========================================
+ Coverage 91.51% 91.55% +0.04%
==========================================
Files 198 199 +1
Lines 8243 8246 +3
==========================================
+ Hits 7543 7549 +6
+ Misses 700 697 -3 |
tophyr
force-pushed
the
devel
branch
2 times, most recently
from
cf9e52c to
d6c0efe
Compare
This was referenced Dec 4, 2023
tophyr
force-pushed
the
devel
branch
3 times, most recently
from
e0e9e73 to
d6c0efe
Compare
|
I've ended up eliminating the RTTI sections of this PR - users can look up RTTI in their |
|
@horenmar when you get some time, would love eyes on this and any feedback or thoughts. |
Catch2 produces tests names with spaces by default when using type-parametric macros like `TEMPLATE_TEST_CASE` and `TEMPLATE_PRODUCT_TEST_CASE`. For some test-runners that are incompatible with spaces in test names, this presents a significant problem: It's possible to define a test that's impossible to run. This adds a `CATCH_CONFIG_NAME_SEPARATOR` configuration value that can be used to override the separator string used during test naming.
It's not often very useful to name tests simply by incrementing numbers. This change adds a mechanism by which a name can be generated using both the index of the type in the type list, and also some from the type itself somehow.
|
Rebased to 3.5.0 |
|
pingping @horenmar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch2 generates names for the
TEMPLATE_*style test definition macros, and the naming can be improved somewhat. This PR adds the ability to control the separator - for situations where external forces might preclude things like spaces in a test name - and also the ability to specify a string associated with a type for a template-list test.Addresses Issue #2542