fix: define velero s3 bucket ownership controls #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed as stale (we mostly talk in Discord, but now we have events from github going there. If you still have an issue, rebase and make a new PR or we can help in Discord if a dialogue is needed. (See org profile for Discord invite link) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Thanks for making these modules open source!
While trying this out I ran into an issue during provisioning due to an API change on AWS' side:
Error: error creating S3 bucket ACL for <bucket-name>: AccessControlListNotSupported: The bucket does not allow ACLs), you need to run terraform applyDefining the object ownership as
ObjectWriterappears to be the solution to retain the ACL as defined. I think it would also be possible to use a different setting and skip the ACL, but I'm not exactly sure how this ACL is used.