Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track_only_students and categories added to admin settings #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piccard21
Copy link

In big installations, like universities have for example, it isn't always wanted to track everything and everybody, One thing is the heavy load you get on the server, the other one is the flood of unnecassary data you normally don't wanna have. In our university for example, it was wanted to track just certain categories and also only students, who are visiting a course. So I added these two options in your admin settings. Maybe you find it useful and want to add it. Sorry for not having added tests to it:-(

@dmitriim
Copy link
Member

dmitriim commented Feb 2, 2021

hi @piccard21
Thank you for the pull request. Before we can properly have a look at it can you please clean up your changes:

  1. revert permission chnages
  2. revert changes to all classes like https://github.com/catalyst/moodle-tool_webanalytics/pull/37/files#diff-cb9efb0b962f082e097ea922ad4e08b1f1dd6e3626de2094ddd93f932525f734R40

After that it will be ready for review. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants