-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finishing touches on superset before user testing #3888
Finishing touches on superset before user testing #3888
Conversation
…, increase superset cloud run resources
limits = { | ||
cpu = "4" | ||
memory = "2048Mi" | ||
memory = "4096Mi" | ||
} | ||
startup_cpu_boost = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to play around with the Cloud Run resources and superset row limit to make everything feel smooth. I decided not to allocate a minimum number of instances because it would cost us about $200 a month. I figured a memory and start CPU boost was reasonable.
depends_on: | ||
- postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker throws an error when you run the prod
profile because the postgres
services isn't started.
python ./automation/create_table_dashboards.py [TABLE_NAMES]... | ||
``` | ||
|
||
### Limitations / Open questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deserving of a more thorough right up which we can do later if we want to move superset into production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bulk of this is the Superset API client, which seems fine, though the whole system feels a little bit like a house of cards - we're definitely trying to force Superset into something it doesn't want to do with all this dashboard-automation-for-an-alternative-UI thing...
f49ea32
into
adjust-usage-metrics-gcp-permissions
* Add dashboard creation automation, fix docker compose error, add logo, increase superset cloud run resources * Add jinja extensnion to template
* Give usage metric archiver sa bucket get permission and add mapbox api key to superset * Add logo to superset, enable horizontal filtering and tagging system * Finishing touches on superset before user testing (#3888) * Add dashboard creation automation, fix docker compose error, add logo, increase superset cloud run resources * Add jinja extensnion to template
Overview
This PR addresses the remaining high priority tasks in #3867:
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list