feat(cors): enable cors/options preflight for all API routes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zbouziane could you take a look at this PR and let me know if it solves your issue with CORS. |
bonjourmauko
referenced
this pull request
in etalab/transport-datatools-server
Jul 19, 2017
Mtc fixes
|
@zbouziane, is this still something you all need? Thanks. |
|
Closing this PR due to inaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zbouziane here's an update for cors to fix #2.
This adds config properties to customize the cors origins, headers, and methods. It also adds
SparkUtils.enableCorsand cleans up some lingering code inDataManager.