Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to remove duplicates in pyserini.encode and pyserini.search.faiss #2008

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Refactoring to remove duplicates in pyserini.encode and pyserini.search.faiss #2008

wants to merge 6 commits into from

Conversation

lintool
Copy link
Member

@lintool lintool commented Oct 8, 2024

Addresses #1728 which will in turn contributes to #2006

@lintool lintool marked this pull request as draft October 8, 2024 03:36
@lintool lintool requested a review from MXueguang October 8, 2024 11:59
@lintool lintool mentioned this pull request Oct 8, 2024
Open
@lintool
Copy link
Member Author

lintool commented Oct 9, 2024

  • I've reconciled the two different versions of QueryEncoder and the two versions of AutoQueryEncoder; retaining only the version in pyserini.encode.
  • Also de-dupped the encoder implementations in pyserini.search.faiss, folding into pyserini.encode as appropriate.
  • Only remaining encoders in pyserini.search.faiss._searcher.py are ClipQueryEncoder and OpenAIQueryEncoder, which I'll refactor in a subsequent pass.

This closes #2009

Running tests right now. After confirming they pass, will be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MXueguang MXueguang Awaiting requested review from MXueguang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lintool