Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete code in Castle.Facilities.Logging #636

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Remove obsolete code in Castle.Facilities.Logging #636

merged 5 commits into from
Jul 20, 2023

Commits on Jan 22, 2023

  1. Rework LoggingFacility to remove obsolete code and LoggerImplementation

    @Jevonius
    Jevonius committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    9b794b5 View commit details
    Browse the repository at this point in the history

  2. Remove CASTLE_SERVICES_LOGGING FEATURE_EVENTLOG conditional compilati… 

    …on symbols as they're no longer required

The tests now work across all target frameworks.
    @Jevonius
    Jevonius committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    52e224a View commit details
    Browse the repository at this point in the history

  3. Remove explicit references to Microsoft.TestPlatform.ObjectModel

    @Jevonius
    Jevonius committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    1e4dd3c View commit details
    Browse the repository at this point in the history

  4. Revert removal of Microsoft.TestPlatform.ObjectModel.11.0.0 

    This works around an issue with NUnit3TestAdapter private referencing this version, stopping assembly binding redirects, and Windsor struggling to call `GetExportedTypes` as a result.
    @Jevonius
    Jevonius committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    c42781e View commit details
    Browse the repository at this point in the history

  5. Update documentation to reflect changes to logging facility

    @Jevonius
    Jevonius committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    f021840 View commit details
    Browse the repository at this point in the history