Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Castle.Core to 5.0.0 (resolves #612) #613

Merged
merged 14 commits into from
Jul 19, 2022
Merged

Upgrade Castle.Core to 5.0.0 (resolves #612) #613

merged 14 commits into from
Jul 19, 2022

Conversation

Jevonius
Copy link
Contributor

Implements #612, specifically:

  • Updates Castle.Core references to 5.0.0
  • Changes net45 target to net462
  • Removes obsolete FEATURE_NETCORE_REFLECTION_API

@Jevonius
Copy link
Contributor Author

Jevonius commented May 14, 2022 •
edited
Loading

Updated target frameworks:

Castle.Facilities.AspNet.Mvc = net462
Castle.Facilities.AspNet.Mvc.Tests = net462
Castle.Facilities.AspNet.SystemWeb = net462
Castle.Facilities.AspNet.SystemWeb.Tests = net462
Castle.Facilities.AspNet.WebApi = net462
Castle.Facilities.AspNet.WebApi.Tests = net462
Castle.Facilities.AspNetCore = netstandard2.0
Castle.Facilities.AspNetCore.Tests = netcoreapp3.1
Castle.Facilities.Logging = net462; netstandard2.0
Castle.Facilities.WcfIntegration = net462
Castle.Facilities.WcfIntegration.Demo = net462
Castle.Facilities.WcfIntegration.Tests = net462
Castle.Windsor = net462; netstandard2.0
Castle.Windsor.Extensions.DependencyInjection = netstandard2.0
Castle.Windsor.Extensions.DependencyInjection.Tests = netcoreapp3.1
Castle.Windsor.Tests = net462; netcoreapp3.1

@Jevonius Jevonius changed the title Upgrade Castle.Core to 5.0.0 Upgrade Castle.Core to 5.0.0 (resolves #612) May 14, 2022
@Jevonius
Update minimum framework version to 4.6.2
a37534b 
castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Remove FEATURE_NETCORE_REFLECTION_API and related code
d97e3c2 
This is dead code; with the previous switch to netstandard2.0, the missing functions became available  and this code stopped being built.

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Switch Castle.Core vreferences to >=5, <6
c97e18f 
castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Switch usage of deprecated Castle.Core.Pair to System.Tuple
f61b668 
castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Fix typo in diagnostic message
73bcc00
@Jevonius
Swap use of deprecated FindAll method to Where/ToArray
dd4a0c9 
castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Restore IsGranted extension method deprecated in Castle.Core
143e0af 
Castler.Core deprecated CAS handling (castleproject/Core#502), this commit restores the relevant method and associated test.

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Standardise null-or-empty checks, resolves deprecated IsNullOrEmpty…
0cf617c 
… helper method

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Update proxy generation to handle deprecation of `DelegateProxyGenera…
db759e7 
…tor`

See castleproject/Core@66ad575 for more information

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Switch assert to catch ArgumentException as `InvalidProxyConstructo…
4b4a20c 
…rArgumentsException` is deprecated

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Update copyright years for files that have been changed as part of ca…
f0ad3e1 
…stleproject#612

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius
Handle variation in how ArgumentException message is formatted depend…
efc5d28 
…ing on runtime

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@ismcagdas ismcagdas mentioned this pull request May 24, 2022
Closed
@Jevonius
Move PermissionUtil to internal namespace, remove test case
2fbbfc1 
Windsor doesn't have internals visible to test projects, and not worth adding for one test case. This is code brought across unchanged from `Castle.Core` and is likely to be deprecated soon, as CAS is phased out.

castleproject#612 - Updating Windsor to support [email protected] and modern TFMs
@Jevonius Jevonius requested a review from jonorossi June 22, 2022 08:37
@Jevonius Jevonius mentioned this pull request Jul 19, 2022
Closed
@jonorossi jonorossi merged commit 1973e70 into castleproject:master Jul 19, 2022
@jonorossi jonorossi added this to the v6.0.0 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jevonius @jonorossi