Remove redundant method accessibility checks & optimize ProxyUtil.IsAccessibleMethod
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Sep 10, 2023
| { | ||
| return false; | ||
| } | ||
| // NOTE: at this point, the method's accessibility should already have been checked (see `AddMethod` above) |
There was a problem hiding this comment.
The only code execution paths leading here look like this:
AddMethod → the various collectors' GetMethodToGenerate methods ( → AcceptMethod ) → AcceptMethodPreScreen
stakx
changed the title
stakx
changed the title
ProxyUtil.IsAccessibleMethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly straightforward refactoring. If there are no comments to the contrary, I'll probably go ahead and merge this pretty soon.
(PS: This PR does not contain anything nefarious, despite its somewhat suspicious number. 😈)