sapadc fixes #57
Open
sapadc fixes #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`\_` isn't even a valid escape character
This is hacky and really points the finger at katcp for not being type stable
|
@kiranshila I think we took so long to merge this, that it may have been superseded by Wei's fix on the py38-dev branch, apologies. Do you want to see if that fix is satisfactory, or if you want additional changes? |
|
I believe this is all fixed on py38-dev, but I'll check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54 and #55, although I'm not quite sure if the clock switch fix works yet.
Also, this includes the fix from #52