Fix a bug with Modifier.flex() nested in a row and column #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Oct 3, 2024
| widthConstraint == Constraint.Fill -> widthSize.toFloat() | ||
| else -> Size.UNDEFINED | ||
| }, | ||
| requestedHeight = when { | ||
| heightMode == MeasureSpec.EXACTLY -> heightSize.toFloat() | ||
| heightMode == MeasureSpec.UNSPECIFIED -> Size.UNDEFINED |
There was a problem hiding this comment.
Without the fix this nested spacer is asked to size itself using (mode=AT_MOST, size=0) and it returns a height of 0.
JakeWharton
approved these changes
Oct 4, 2024
This is a bug in Android only caused by not explicitly handling MeasureSpec.UNSPECIFIED.
swankjesse
force-pushed
the
jwilson.1003.flex_nested
branch
from
91e8f4c
to
703fe99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug in Android only caused by not explicitly handling MeasureSpec.UNSPECIFIED.
Closes: #2018