Send widget tag with property change #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
approved these changes
Oct 2, 2024
JakeWharton
force-pushed
the
jw.widget-tag.2024-10-02
branch
from
2d4b2c7
to
abcbf03
Compare
This will enable a future change to perform property value deserialization on the Zipline thread. Previously only the ID of the widget was available, and we can only resolve that to a widget tag on the main thread.
JakeWharton
force-pushed
the
jw.widget-tag.2024-10-02
branch
from
abcbf03
to
6f833db
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable a future change to perform property value deserialization on the Zipline thread. Previously only the ID of the widget was available, and we can only resolve that to a widget tag on the main thread.
I manually tested an old host with new guest to ensure it would ignore this property.
Needs to be rebased on #2354 to pass API check(done). Part of #2145.CHANGELOG.md's "Unreleased" section has been updated, if applicable.