Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single toString implementation for protocol nodes #2345

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

JakeWharton
Copy link
Collaborator

This saves even more. For emoji sample:

  • Before: 11299596
  • After: 10953834

  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@JakeWharton JakeWharton force-pushed the jw.one-to-string-to-rule-them-all.2024-09-30 branch from 9c21926 to daebed3 Compare October 1, 2024 00:13
This saves even more. For emoji sample:

 - Before: 11299596
 - After: 10953834
@JakeWharton JakeWharton force-pushed the jw.one-to-string-to-rule-them-all.2024-09-30 branch from daebed3 to 8b25d41 Compare October 1, 2024 02:11
Copy link
Member

@colinrtwhite colinrtwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JakeWharton JakeWharton merged commit 26d5056 into trunk Oct 1, 2024
11 checks passed
@JakeWharton JakeWharton deleted the jw.one-to-string-to-rule-them-all.2024-09-30 branch October 1, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants