Create a widget protocol descriptor type #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.property-on-bg-thread.2024-09-19
branch
from
ba6e10d
to
7934954
Compare
JakeWharton
force-pushed
the
jw.property-on-bg-thread-2.2024-09-30
branch
2 times, most recently
from
48c6985
to
972782f
Compare
Base automatically changed from
jw.property-on-bg-thread.2024-09-19
to
trunk
September 30, 2024 21:37
JakeWharton
force-pushed
the
jw.property-on-bg-thread-2.2024-09-30
branch
from
972782f
to
cb71a40
Compare
This has knowledge of the child IDs for this widget as well as the ability to create instances of it. In the future this will also hold more information such as property IDs so that we can deserialize them on the Zipline thread.
JakeWharton
force-pushed
the
jw.property-on-bg-thread-2.2024-09-30
branch
from
cb71a40
to
3378432
Compare
colinrtwhite
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has knowledge of the child IDs for this widget as well as the ability to create instances of it.
In the future this will also hold more information such as property IDs so that we can deserialize them on the Zipline thread.
Part of #2145.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.