Add a test to demonstrate a layout bug in Yoga (#2346)

* Add a test to demonstrate a layout bug in Yoga We've accidentally set the maximum width of a cell to its maximum height. * Use fewer 'A's in the snapshot
cashapp · Oct 1, 2024 · 98c04fc · 98c04fc
1 parent d5a72d9
commit 98c04fc
Show file tree

Hide file tree

Showing 11 changed files with 51 additions and 0 deletions.
diff --git a/...omposeUiFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png b/...omposeUiFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png
diff --git a/...omposeUiFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png b/...omposeUiFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png
diff --git a/...ut-shared-test/src/commonMain/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt b/...ut-shared-test/src/commonMain/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt
@@ -325,6 +325,27 @@ abstract class AbstractFlexContainerTest<T : Any> {
     snapshotter(container.value).snapshot()
   }
 
+  @Test fun testRowWithFixedWidthHasChildWithFixedHeight() {
+    val container = flexContainer(FlexDirection.Row).apply {
+      crossAxisAlignment(CrossAxisAlignment.Start)
+      modifier = WidthImpl(200.dp)
+      width(Constraint.Fill)
+      height(Constraint.Fill)
+    }
+
+    widgetFactory.text("A ".repeat(10)).apply {
+      modifier = HeightImpl(50.dp)
+      container.children.insert(0, this)
+    }
+
+    widgetFactory.text("B ".repeat(100)).apply {
+      container.children.insert(1, this)
+    }
+
+    container.onEndChanges()
+    snapshotter(container.value).snapshot()
+  }
+
   @Test fun testChildWithUpdatedProperty() {
     val container = flexContainer(FlexDirection.Column)
     val snapshotter = snapshotter(container.value)

diff --git a/.../UIViewFlexContainerTestHost/testRowWithFixedWidthHasChildWithFixedHeight.1.png b/.../UIViewFlexContainerTestHost/testRowWithFixedWidthHasChildWithFixedHeight.1.png
diff --git a/...iew_ViewFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png b/...iew_ViewFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png
diff --git a/...iew_ViewFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png b/...iew_ViewFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png
diff --git a/...eui_ComposeUiLazyListTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png b/...eui_ComposeUiLazyListTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png
diff --git a/...eui_ComposeUiLazyListTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png b/...eui_ComposeUiLazyListTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png
diff --git a/...yListAsFlexContainerTestHost/testRowWithFixedWidthHasChildWithFixedHeight.1.png b/...yListAsFlexContainerTestHost/testRowWithFixedWidthHasChildWithFixedHeight.1.png
diff --git a/...zyListAsFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png b/...zyListAsFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[LTR].png
diff --git a/...zyListAsFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png b/...zyListAsFlexContainerTest_testRowWithFixedWidthHasChildWithFixedHeight[RTL].png