Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the horizontal angular velocity to zero #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tongtybj
Copy link

@tongtybj tongtybj commented Jul 3, 2018

I think the angular velocity regarding to x and y axis is useless, in the case of 2d mapping.
Maybe these values are omitted in the latest cartographer if use_trajectory_builder_2d is true.

However, we are trying to use the debianized cartographer in ros kinetic distro, which is based on version 0.2.0, and I found that the horizontal angular velocity effects significantly on the localization as shown in the following GIF.
old_cartographer_without_acml

After applying this commit, the localization is improved a lot as shown in the following GIF.
old_cartographer_without_xy_gyro

Please think about to merge this commit.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tongtybj
Copy link
Author

tongtybj commented Jul 3, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 3, 2018
@tongtybj
Copy link
Author

tongtybj commented Jul 3, 2018 via email

Copy link
Contributor

@gaschler gaschler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to improve the published pose (most likely PoseExtrapolator results in cartographer_ros are improved).
I don't see much change in the map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants