-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up an initial CI with colcon on ROS2 Dashing & Foxy. #1543
Open
MichaelGrupp
wants to merge
6
commits into
cartographer-project:ros2-dashing
Choose a base branch
from
MichaelGrupp:ros2-dashing-ci-initial
base: ros2-dashing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
df0a414
Remove unneeded, ROS 1 specific CI files.
MichaelGrupp 70b03e4
Port build scripts from catkin to colcon.
MichaelGrupp 51e6934
Run CI with Dockerfiles for Foxy and Dashing.
MichaelGrupp 433e5e6
Deactivate cartographer_ros modules build for now.
MichaelGrupp 8848743
Adapt rosdep paths of install_debs.sh
MichaelGrupp cc8a0db
Adapt comment in Dcokerfile.
MichaelGrupp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Copyright 2020 The Cartographer Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
FROM osrf/ros:dashing-desktop | ||
|
||
ARG CARTOGRAPHER_VERSION=master | ||
|
||
# We require a GitHub access token to be passed. | ||
ARG github_token | ||
|
||
# The base image doesn't ship with sudo and wstool. | ||
RUN apt-get update && apt-get install -y sudo python3-wstool | ||
|
||
# First, we invalidate the entire cache if cartographer-project/cartographer has | ||
# changed. This file's content changes whenever master changes. See: | ||
# http://stackoverflow.com/questions/36996046/how-to-prevent-dockerfile-caching-git-clone | ||
ADD https://api.github.com/repos/cartographer-project/cartographer/git/refs/heads/master?access_token=$github_token \ | ||
cartographer_ros/cartographer_version.json | ||
|
||
# wstool needs the updated rosinstall file to clone the correct repos. | ||
COPY cartographer_ros.rosinstall cartographer_ros/ | ||
COPY scripts/prepare_dev_workspace.sh cartographer_ros/scripts/ | ||
RUN CARTOGRAPHER_VERSION=$CARTOGRAPHER_VERSION \ | ||
cartographer_ros/scripts/prepare_dev_workspace.sh | ||
|
||
# rosdep needs the updated package.xml files to install the correct debs. | ||
COPY cartographer_ros/package.xml dev_ws/src/cartographer_ros/cartographer_ros/ | ||
COPY cartographer_ros_msgs/package.xml dev_ws/src/cartographer_ros/cartographer_ros_msgs/ | ||
COPY cartographer_rviz/package.xml dev_ws/src/cartographer_ros/cartographer_rviz/ | ||
COPY scripts/install_debs.sh cartographer_ros/scripts/ | ||
RUN cartographer_ros/scripts/install_debs.sh | ||
|
||
# Install Abseil. | ||
RUN /dev_ws/src/cartographer/scripts/install_abseil.sh | ||
|
||
# Build, install, and test all packages individually to allow caching. The | ||
# ordering of these steps must match the topological package ordering. | ||
COPY scripts/install_and_test.sh cartographer_ros/scripts/ | ||
|
||
RUN cartographer_ros/scripts/install_and_test.sh cartographer | ||
|
||
# TODO(MichaelGrupp): Activate all build steps for ROS2 once they work. | ||
# COPY cartographer_ros_msgs dev_ws/src/cartographer_ros/cartographer_ros_msgs | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_ros_msgs | ||
|
||
# COPY cartographer_ros dev_ws/src/cartographer_ros/cartographer_ros | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_ros | ||
|
||
# COPY cartographer_rviz dev_ws/src/cartographer_ros/cartographer_rviz | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_rviz | ||
|
||
RUN rm -rf /var/lib/apt/lists/* | ||
# A BTRFS bug may prevent us from cleaning up these directories. | ||
# https://btrfs.wiki.kernel.org/index.php/Problem_FAQ#I_cannot_delete_an_empty_directory | ||
RUN rm -rf cartographer_ros || true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Copyright 2020 The Cartographer Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
FROM osrf/ros:foxy-desktop | ||
|
||
ARG CARTOGRAPHER_VERSION=master | ||
|
||
# We require a GitHub access token to be passed. | ||
ARG github_token | ||
|
||
# The base image doesn't ship with sudo and wstool. | ||
RUN apt-get update && apt-get install -y sudo python3-wstool | ||
|
||
# First, we invalidate the entire cache if cartographer-project/cartographer has | ||
# changed. This file's content changes whenever master changes. See: | ||
# http://stackoverflow.com/questions/36996046/how-to-prevent-dockerfile-caching-git-clone | ||
ADD https://api.github.com/repos/cartographer-project/cartographer/git/refs/heads/master?access_token=$github_token \ | ||
cartographer_ros/cartographer_version.json | ||
|
||
# wstool needs the updated rosinstall file to clone the correct repos. | ||
COPY cartographer_ros.rosinstall cartographer_ros/ | ||
COPY scripts/prepare_dev_workspace.sh cartographer_ros/scripts/ | ||
RUN CARTOGRAPHER_VERSION=$CARTOGRAPHER_VERSION \ | ||
cartographer_ros/scripts/prepare_dev_workspace.sh | ||
|
||
# rosdep needs the updated package.xml files to install the correct debs. | ||
COPY cartographer_ros/package.xml dev_ws/src/cartographer_ros/cartographer_ros/ | ||
COPY cartographer_ros_msgs/package.xml dev_ws/src/cartographer_ros/cartographer_ros_msgs/ | ||
COPY cartographer_rviz/package.xml dev_ws/src/cartographer_ros/cartographer_rviz/ | ||
COPY scripts/install_debs.sh cartographer_ros/scripts/ | ||
RUN cartographer_ros/scripts/install_debs.sh | ||
|
||
# Install Abseil. | ||
RUN /dev_ws/src/cartographer/scripts/install_abseil.sh | ||
|
||
# Build, install, and test all packages individually to allow caching. The | ||
# ordering of these steps must match the topological package ordering. | ||
COPY scripts/install_and_test.sh cartographer_ros/scripts/ | ||
|
||
RUN cartographer_ros/scripts/install_and_test.sh cartographer | ||
|
||
# TODO(MichaelGrupp): Activate all build steps for ROS2 once they work. | ||
# COPY cartographer_ros_msgs dev_ws/src/cartographer_ros/cartographer_ros_msgs | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_ros_msgs | ||
|
||
# COPY cartographer_ros dev_ws/src/cartographer_ros/cartographer_ros | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_ros | ||
|
||
# COPY cartographer_rviz dev_ws/src/cartographer_ros/cartographer_rviz | ||
# RUN cartographer_ros/scripts/install_and_test.sh cartographer_rviz | ||
|
||
RUN rm -rf /var/lib/apt/lists/* | ||
# A BTRFS bug may prevent us from cleaning up these directories. | ||
# https://btrfs.wiki.kernel.org/index.php/Problem_FAQ#I_cannot_delete_an_empty_directory | ||
RUN rm -rf cartographer_ros || true |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really familiar with how cartographer CI generally works, but shouldn't this be
ros2-dashing
? Same for Dockerfile.foxy below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just means that we use
master
of the cartographer core library. The ROS part is the correct branch.