Update directory walking to be multithreaded #33
+90
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
reviewed
Dec 26, 2024
| let entries = jwalk::WalkDir::new(root.clone()).process_read_dir(|_, _, _, children| { | ||
| children.iter_mut().for_each(|dir_entry_result| { | ||
| if let Ok(dir_entry) = dir_entry_result { | ||
| if dir_entry.path().starts_with(".") || dir_entry.file_name.eq_ignore_ascii_case("node_modules") { |
There was a problem hiding this comment.
we shouldn't ignore node_modules, while usually it does not contain PHP code, it could.
people using node alongside PHP should manually add this to their exclude directory.
There was a problem hiding this comment.
What do you mean it could?
Comment on lines
+46
to
+49
| for entry in entries { | ||
| if let Err(_) = entry { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
we should return the error here instead of ignoring it, if the directory is not readable for example, it should be excluded.
There was a problem hiding this comment.
What do you suggest? I wouldn't stop the loop, I would just log the error to the user
Co-authored-by: Saif Eddin Gmati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I try to test most cases and it seems that the behaviour is the same or even improved. For example in the excludes now both
**/vendor/composer/*andvendor/composer/*works.Regarding the dir walking:
.and node_modules folders. This folder it's something new but I can't really think of a reason why we shouldn't ignore it, it's pretty common, has a huge amount of dirs and files, and it's not PHP.I am fairly new rust so hopefully this looks good enough