Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add prevrandao field to EvmAdvance #62

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

mpolitzer
Copy link
Collaborator

@mpolitzer mpolitzer commented May 20, 2024

rollups-contracts and the machine must agree on the inputs and outputs:

Field added here: cartesi/rollups-contracts@95a5a14

@mpolitzer mpolitzer requested a review from diegonehab May 20, 2024 13:35
@vfusco vfusco added this to the v0.16.0 milestone May 20, 2024
@mpolitzer mpolitzer requested a review from a team May 23, 2024 14:48
@mpolitzer mpolitzer force-pushed the feat/prevrandao branch 6 times, most recently from 2a52a99 to 4655901 Compare May 29, 2024 13:40
Copy link
Contributor

@diegonehab diegonehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@mpolitzer mpolitzer force-pushed the feat/prevrandao branch 2 times, most recently from be43b46 to c15877d Compare June 3, 2024 13:33
Copy link
Contributor

@diegonehab diegonehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

rework libcmt to use stronger types
rename CMT_ADDRESS_LENGTH to CMT_ABI_ADDRESS_LENGTH
rename CMT_ABI_WORD_LENGTH to CMT_ABI_U256_LENGTH

port rust code to new API
port rollup code to the new API
port ioctl-echo-loop code to the new API

split header files into a separate folder. This allows users to build
and link without a installing by preserving the header files relative
path and `-I<cmt-root-dir>/include` when building.
Copy link
Contributor

@diegonehab diegonehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve if @alexmikhalevich approves. :)

@mpolitzer mpolitzer merged commit 194a7df into main Jun 21, 2024
5 checks passed
@mpolitzer mpolitzer deleted the feat/prevrandao branch June 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants