feat: use init and entrypoint from device tree #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edubart
force-pushed
the
feature/new-init
branch
2 times, most recently
from
2a08055
to
506f21e
Compare
edubart
force-pushed
the
feature/new-init
branch
8 times, most recently
from
70b67d3
to
0ca8aff
Compare
This was
linked to
issues
Aug 14, 2023
edubart
force-pushed
the
feature/new-init
branch
from
0ca8aff
to
1d54f45
Compare
edubart
force-pushed
the
feature/new-init
branch
3 times, most recently
from
30d4840
to
37e3f43
Compare
diegonehab
reviewed
Oct 6, 2023
diegonehab
reviewed
Oct 6, 2023
diegonehab
reviewed
Oct 6, 2023
skel/opt/cartesi/bin/init
Outdated
| cd $HOME && | ||
| # use entrypoint from device tree when available, otherwise from command line | ||
| if [ -s /proc/device-tree/cartesi-machine/entrypoint ]; then | ||
| ENTRYPOINT=$(busybox cat /proc/device-tree/cartesi-machine/entrypoint) |
There was a problem hiding this comment.
Do we need to load this from string if we drop support for entrypoint in the Linux bootargs? Can't we run directly from there?
There was a problem hiding this comment.
Actually I was running /proc/device-tree/cartesi-machine/entrypoint directly at first, but then I thought the error messages of invalid commands were less user friendly, so I decided to load in a string.
Example of an error running directly:
cartesi-machine --quiet --no-init-splash -i invalid-command
sh: /proc/device-tree/cartesi-machine/entrypoint: line 1: invalid-command: not found
Example of an error using a string:
cartesi-machine --quiet --no-init-splash -i invalid-command
sh: invalid-command: not found
I could run directly again, which one you think it is better?
There was a problem hiding this comment.
I don't think the first error message is too bad actually. :)
There was a problem hiding this comment.
Ok, I changed to run it directly.
edubart
force-pushed
the
feature/new-init
branch
from
37e3f43
to
1c7ace4
Compare
edubart
force-pushed
the
feature/new-init
branch
from
1c7ace4
to
09fb3f4
Compare
mpolitzer
approved these changes
Oct 9, 2023
vfusco
approved these changes
Oct 10, 2023
diegonehab
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to:
It fixes: