Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): reorganizing tests/ directory #115

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

endersonmaia
Copy link
Contributor

This pull request includes a series of changes to the integration and unit tests within the CLI application. The changes primarily involve renaming test files and updating import paths and directory references.

Test File Renaming and Path Updates:

  • File Renaming:

    • Renamed integration test files to follow a consistent naming convention. For example, apps/cli/test/builder/directory.test.ts is now apps/cli/tests/integration/builder/directory.test.ts.
    • Similar renaming applied to other test files like docker.test.ts, empty.test.ts, none.test.ts, tar.test.ts, and various exec tests. [1] [2] [3] [4] [5] [6] [7] [8]
  • Import Path Updates:

    • Updated import paths in the renamed test files to reflect their new locations. For example, paths like ../../src/builder/directory are now ../../../src/builder/directory. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Directory Reference Updates:

  • Fixtures Directory:
    • Updated directory references in the tests from data to fixtures for consistency and better organization. For example, path.join(__dirname, "data", "sample1") is now path.join(__dirname, "fixtures", "sample1"). [1] [2] [3] [4] [5] [6] [7] [8]

New Unit Test Additions:

  • Unit Test Enhancements:
    • Added new unit tests for parsing drive config files in apps/cli/tests/unit/config.test.ts. This includes loading and parsing various drive configurations from the fixtures directory. [1] [2]

These changes aim to improve the organization and maintainability of the test suite, ensuring consistent naming conventions and better directory structure.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 6cf0fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 31.4% 298 / 949
🔵 Statements 31.52% 303 / 961
🔵 Functions 37.41% 52 / 139
🔵 Branches 28.11% 122 / 434
File CoverageNo changed files found.
Generated in workflow #207 for commit 6cf0fa2 by the Vitest Coverage Report Action

@endersonmaia endersonmaia merged commit 486380e into prerelease/v2-alpha Oct 23, 2024
2 checks passed
@endersonmaia endersonmaia deleted the refactor/tests-directory branch October 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants