Skip to content

Commit

Permalink
Bump cucumber version to fix ruby-head build
Browse files Browse the repository at this point in the history
  • Loading branch information
mshibuya committed Jan 11, 2025
1 parent 08a3698 commit 0da14db
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
gemfile: gemfiles/rails-main.gemfile
experimental: true
- ruby: ruby-head
gemfile: gemfiles/rails-7-2.gemfile
gemfile: gemfiles/rails-8-0.gemfile
experimental: false
- ruby: jruby
gemfile: gemfiles/rails-7-0.gemfile
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ end

desc "Run cucumber features"
Cucumber::Rake::Task.new(:features) do |t|
t.cucumber_opts = "features --format progress"
t.cucumber_opts = %w[features --format progress]
end

task :default => [:spec, :features]
2 changes: 1 addition & 1 deletion carrierwave.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Gem::Specification.new do |s|
s.add_dependency "addressable", "~> 2.6"
s.add_dependency "ssrf_filter", "~> 1.0"
s.add_development_dependency "csv", "~> 3.0"
s.add_development_dependency "cucumber", "~> 2.3"
s.add_development_dependency "cucumber"
s.add_development_dependency "rspec", "~> 3.4"
s.add_development_dependency "rspec-retry"
s.add_development_dependency "rubocop", "~> 1.28"
Expand Down
2 changes: 1 addition & 1 deletion cucumber.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
default: --format pretty --no-source
default: --format pretty --no-source --publish-quiet
html: --format html --out features.html
2 changes: 2 additions & 0 deletions gemfiles/rails-8-0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,7 @@ gem "rails", "~> 8.0.0"
gem "activemodel-serializers-xml"
gem "sqlite3", platforms: :ruby
gem "activerecord-jdbcsqlite3-adapter", platform: [:jruby, :truffleruby]
# Until https://github.com/cucumber/cucumber-ruby/pull/1757 gets released
gem "cucumber", github: "cucumber/cucumber-ruby" if RUBY_VERSION.to_f >= 3.4

gemspec :path => "../"

0 comments on commit 0da14db

Please sign in to comment.