Add functions for (de)activating local minicran install as repo #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports activating and deactivating use of the local pypi mirror by pip
Different line endings and path characters were causing issues on Windows
|
Fixed a missing dev dependency and a cross-OS testing issue. Tests are passing now. |
abhidg
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Thanks @ethanwhite and apologies for the delayed review. Could you add tests for deactivation? The Python pip.conf modifies multiple lines, so that's the one that might be an issue.
|
|
||
| minicran_path = os.path.join("file://", ods_dir.lstrip("/"), "miniCRAN") #lstrip needed because "If any component is an absolute path, all previous path components will be discarded" | ||
| rprofile_line = 'local({r <- getOption("repos"); r["CRAN"] <- "%s"; options(repos=r)}) #Added by offlinedatasci\n' % minicran_path | ||
| rprofile_path = Path(os.path.join(os.path.expanduser("~"), ".Rprofile")) |
There was a problem hiding this comment.
can be shortened to Path("~/.Rprofile").expanduser()
| else: | ||
| activated = False | ||
| for line in pip_config_list: | ||
| if line.strip() == pip_config_line.strip(): |
There was a problem hiding this comment.
Unlike the R case, multiple lines are in pip_config_line, so any particular line will never match the whole of pip_config_line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For advanced users installing from a local repo mirror is fairly easy, but for novices and even a lot of experienced coders this would involve learning a lot of details they probably don't care about. For workshops with Raspberry PI style servers this would be handled via instruction, but for folks using
offlinedatascilocally it might be a bit confusing.This PR adds the ability to run
offlinedatasci activate /path/to/ods, which will add lines to both~/.Rprofileand~/.config/pip/pip.confthat will causeinstall.packages()andpip installto use the associated offlinedatasci local mirrors.offlinedatasci deactivatewill remove all such lines to return these files to their previous state and behavior to normal.I'm definitely interested in reviews of this since it's messing with users conf files.
Should we prompt the user to confirm this change? Is it a bad idea in general? Other thoughts?