Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #546] add human language in workshop description #625

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

[fix #546] add human language in workshop description #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc8d63
[fix #546] add human language in workshop description
fmichonneau Oct 11, 2019
25e9820
incorporate @maxim-belkin comments
fmichonneau Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ flavor: "r"
# https://github.com/carpentries/workshop-template#creating-extra-pages
title: "Workshop Title"

## human_language: the language in which the workshop is taught.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest listing couple of examples after this first line, e.g. "English", "Dutch", etc.

# If set to anything other than "", a note about the language
# of the workshop is added to the workshop description.
human_language: ""

#------------------------------------------------------------
# Generic settings (should not need to change).
Expand Down
14 changes: 14 additions & 0 deletions index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,20 @@ workshop is only open to people from a particular institution.
{% include lc/who.html %}
{% endif %}

{% comment %}
HUMAN LANGUAGE
{% endcomment %}

{% unless site.human_language == "" %}
<p id="human-language">
<strong>The workshop will be conducted in {{ site.human_language }}.</strong>
For this course, we will expect our participants to have basic understanding
of {{ site.human_language }}. We will have several helpers to assist you if
you need assistance with understanding the lesson material.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "with" in the last line does not need to be here.

I do still find this somewhat confusing. Is the idea that the helpers will be fluent in both the workshop language and another language to help with translation?

Maybe there should be two fields in config (I don't love this proposal, but thinking together is better than alone):
workshop-human-language and local-human-language and then display the paragraph if those do not match (with appropriate update to the comment)? and in the reference to helpers can note that the helpers will be competent in both workshop and local languages? @malvikasharan @raynamharris would that be helpful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think that the intent was that helpers would be proficient both language and could help with translation if needed. That sentence I took from @malvikasharan's workshop might be too specific to be generalizable to all workshops, and it might be best to leave it out?

</p>
{% endunless %}


{% comment %}
LOCATION

Expand Down