Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of entries for each language #110

Closed
wants to merge 2 commits into from

Conversation

fmichonneau
Copy link
Contributor

proposed solution for #109

Still needed:

  • currently "entries" is in English for all languages
  • tweaks to the CSS to differentiate it from the rest of the text would be good.

if anyone wants to contribute to these 2 points, please feel free to do so.

@zkamvar zkamvar added documentation Improvements or additions to documentation infrastructure labels Oct 7, 2020
@baileythegreen
Copy link
Contributor

baileythegreen commented Dec 2, 2020

@fmichonneau

I think the translation of 'entries' dovetails nicely with a feature I'm working on, which is part-of-speech information in the appropriate language for each page.

I haven't pushed this yet, but I can add 'entries' to the yaml translate file I have and then push to this branch once I've finished? Or is there a better idea?

I can also do the CSS. Do you want me to just make a decision about how it should look, or did you have an idea?

@fmichonneau
Copy link
Contributor Author

Thanks @baileythegreen!

I haven't pushed this yet, but I can add 'entries' to the yaml translate file I have and then push to this branch once I've finished? Or is there a better idea?

That sounds like a good approach given our current tooling.

I can also do the CSS. Do you want me to just make a decision about how it should look, or did you have an idea?

That would be great. I don't have a specific idea. I just thought it would be better if the number of entries didn't stand out too much to keep the focus on the language and the introduction to the project.

@fmichonneau fmichonneau deleted the add-n-entries branch November 16, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants